fstests.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Filipe Manana <fdmanana@gmail.com>
To: Qu Wenruo <wqu@suse.com>
Cc: fstests <fstests@vger.kernel.org>,
	linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 1/3] fstests: common: Use more accurate kernel config for _require_fail_make_request
Date: Tue, 17 Dec 2019 17:24:50 +0000	[thread overview]
Message-ID: <CAL3q7H50wBGvT1dVFh0MSZ7V=690Eek86pYq_ct2CN2aViGFHg@mail.gmail.com> (raw)
In-Reply-To: <20191211104029.25541-2-wqu@suse.com>

On Wed, Dec 11, 2019 at 10:40 AM Qu Wenruo <wqu@suse.com> wrote:
>
> Just enabling CONFIG_FAIL_MAKE_REQUEST will not fulfill
> _require_fail_make_request.
>
> It's CONFIG_FAULT_INJECTION_DEBUG_FS.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>

Reviewed-by: Filipe Manana <fdmanana@suse.com>

Thanks.

> ---
>  common/rc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/rc b/common/rc
> index 5cdd829b..2d72f158 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -2357,7 +2357,7 @@ _require_fail_make_request()
>  {
>      [ -f "$DEBUGFS_MNT/fail_make_request/probability" ] \
>         || _notrun "$DEBUGFS_MNT/fail_make_request \
> - not found. Seems that CONFIG_FAIL_MAKE_REQUEST kernel config option not enabled"
> + not found. Seems that CONFIG_FAULT_INJECTION_DEBUG_FS kernel config option not enabled"
>  }
>
>  # Disable extent zeroing for ext4 on the given device
> --
> 2.23.0
>


-- 
Filipe David Manana,

“Whether you think you can, or you think you can't — you're right.”

  reply	other threads:[~2019-12-17 17:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11 10:40 [PATCH 0/3] fstests: btrfs/15[78] btrfs/14[23]: Use more accurate devid/phsyical for corruption Qu Wenruo
2019-12-11 10:40 ` [PATCH 1/3] fstests: common: Use more accurate kernel config for _require_fail_make_request Qu Wenruo
2019-12-17 17:24   ` Filipe Manana [this message]
2019-12-11 10:40 ` [PATCH 2/3] fstests: btrfs/14[23]: Use proper help to get both devid and physical offset for corruption Qu Wenruo
2019-12-11 11:24   ` Nikolay Borisov
2019-12-17 17:30   ` Filipe Manana
2019-12-11 10:40 ` [PATCH 3/3] fstests: btrfs/15[78]: Use proper helper " Qu Wenruo
2019-12-11 11:24   ` Nikolay Borisov
2019-12-17 17:33   ` Filipe Manana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL3q7H50wBGvT1dVFh0MSZ7V=690Eek86pYq_ct2CN2aViGFHg@mail.gmail.com' \
    --to=fdmanana@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).