From: Matt McCutchen <matt@mattmccutchen.net>
To: git@vger.kernel.org
Subject: "git diff --ignore-space-change --stat" lists files with only whitespace differences as "changed"
Date: Tue, 17 Jan 2017 21:01:55 -0500 [thread overview]
Message-ID: <1484704915.2096.16.camel@mattmccutchen.net> (raw)
A bug report: I noticed that "git diff --ignore-space-change --stat"
lists files with only whitespace differences as having changed with 0
differing lines. This is inconsistent with the behavior without --
stat, which doesn't list such files at all. (Same behavior with all
the --ignore*space* flags.) I can reproduce this with the current
"next", af746e4. Quick test case:
echo ' ' >test1 && echo ' ' >test2 &&
git diff --stat --no-index --ignore-space-change test1 test2
This caused me some inconvenience in the following scenario: I was
reading a commit diff that had a bulk license change in all files
combined with code changes. I attempted to revert the bulk license
change locally using "sed" to more easily read the code diff, but my
reversion left some whitespace diffs where the original files had
inconsistent whitespace. So the diffstat after my reversion was
cluttered with these "0" entries.
Regards,
Matt
next reply other threads:[~2017-01-18 2:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 2:01 Matt McCutchen [this message]
2017-01-18 11:17 ` "git diff --ignore-space-change --stat" lists files with only whitespace differences as "changed" Jeff King
2017-01-18 20:57 ` Junio C Hamano
2017-01-18 21:08 ` Jeff King
2017-01-18 22:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484704915.2096.16.camel@mattmccutchen.net \
--to=matt@mattmccutchen.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).