From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Mark Levedahl <mlevedahl@gmail.com>
Cc: Adam Dinwoodie <adam@dinwoodie.org>,
git@vger.kernel.org, Eric Blake <eblake@redhat.com>,
"Shawn O . Pearce" <spearce@spearce.org>,
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Subject: Re: [PATCH] config.mak.uname: Cygwin: Use renames for creation
Date: Sat, 8 Aug 2015 21:06:28 +0000 [thread overview]
Message-ID: <20150808210627.GB155450@vauxhall.crustytoothpaste.net> (raw)
In-Reply-To: <55C66AF2.3060706@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1321 bytes --]
On Sat, Aug 08, 2015 at 04:47:46PM -0400, Mark Levedahl wrote:
> On 08/07/2015 04:30 PM, Adam Dinwoodie wrote:
> >When generating build options for Cygwin, enable
> >OBJECT_CREATION_USES_RENAMES. This is necessary to use Git on Windows
> >shared directories, and is already enabled for the MinGW and plain
> >Windows builds.
> I've been supporting use of git on cygwin since about 2008, this issue has
> never risen that I know. Whatever issue is being patched around here, if
> truly repeatable, should be handled by the cygwin dll as that code is
> focused on providing full linux compatibility. If git on linux does need
> this patch, git on cygwin should not, either. So, I vote against this.
We've gotten a lot of users on the list who ask why their Git
directories on shared drives aren't working (or are broken in some way).
Since I don't use Windows, let me ask: does the Cygwin DLL handle
link(2) properly on shared drives, and if not, would this patch help it
do so? I can imagine that perhaps SMB doesn't support the necessary
operations to make a POSIX link(2) work properly.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2015-08-08 21:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 20:30 [PATCH] config.mak.uname: Cygwin: Use renames for creation Adam Dinwoodie
2015-08-08 20:47 ` Mark Levedahl
2015-08-08 21:06 ` brian m. carlson [this message]
2015-08-09 2:01 ` Adam Dinwoodie
2015-08-09 9:01 ` Johannes Schindelin
2015-08-09 17:05 ` Adam Dinwoodie
2015-08-10 19:08 ` Junio C Hamano
2015-08-11 10:05 ` Adam Dinwoodie
2015-08-18 15:44 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150808210627.GB155450@vauxhall.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=adam@dinwoodie.org \
--cc=eblake@redhat.com \
--cc=git@vger.kernel.org \
--cc=mlevedahl@gmail.com \
--cc=ramsay@ramsay1.demon.co.uk \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).