From: Jeff King <peff@peff.net>
To: miwilliams@google.com
Cc: git@vger.kernel.org
Subject: Re: your mail
Date: Mon, 11 Apr 2016 15:13:12 -0400 [thread overview]
Message-ID: <20160411191311.GA9057@sigill.intra.peff.net> (raw)
In-Reply-To: <001a11492f107354a305303a369a@google.com>
On Mon, Apr 11, 2016 at 07:04:23PM +0000, miwilliams@google.com wrote:
> From 7201fe08ede76e502211a781250c9a0b702a78b2 Mon Sep 17 00:00:00 2001
> From: Mike Williams <miwilliams@google.com>
> Date: Mon, 11 Apr 2016 14:18:39 -0400
> Subject: [PATCH 1/1] wt-status: Remove '!!' from
> wt_status_collect_changed_cb
These bits (minus the initial "From ..." line) should go into your
actual email headers. As it is, your email has no subject line.
> The wt_status_collect_changed_cb function uses an extraneous double
> negation (!!) when determining whether or not a submodule has new
> commits.
> [...]
> - d->new_submodule_commits = !!hashcmp(p->one->sha1, p->two->sha1);
> + d->new_submodule_commits = hashcmp(p->one->sha1, p->two->sha1);
It's not extraneous. hashcmp() returns 0 for equality, but an arbitrary
positive or negative value depending on how the two arguments differ.
The assigned "new_submodule_commits" is a bitfield of size 1. So the
"!!" is normalizing the value into "0" or "1".
-Peff
next prev parent reply other threads:[~2016-04-11 19:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 19:04 (unknown), miwilliams
2016-04-11 19:13 ` Jeff King [this message]
2016-04-11 19:18 ` none Matthieu Moy
2016-04-12 4:33 ` Stefan Beller
-- strict thread matches above, loose matches on Subject: below --
2020-06-24 0:38 shejan shuza
2020-06-24 1:31 ` your mail brian m. carlson
2019-11-20 3:49 Han-Wen Nienhuys
2019-11-20 5:30 ` your mail Taylor Blau
2019-11-20 8:05 ` Christian Couder
2019-07-11 20:11 Robert Morgan
2019-07-11 20:18 ` your mail Kevin Daudt
2019-07-11 20:25 ` Robert Morgan
2019-01-25 9:47 Furkan DURUL
2019-01-25 11:27 ` your mail Kevin Daudt
2017-06-22 9:50 Jessie Hernandez
2017-06-22 12:48 ` your mail Simon Ruderich
2017-06-22 13:35 ` AW: " Patrick Lehmann
2017-06-22 13:47 ` Simon Ruderich
2017-06-22 13:55 ` AW: " Patrick Lehmann
2017-06-22 20:46 ` Simon Ruderich
2017-06-22 21:35 ` Junio C Hamano
2017-06-22 21:58 ` Ævar Arnfjörð Bjarmason
2017-06-22 22:14 ` Junio C Hamano
2017-06-22 23:21 ` Jeff King
2017-06-23 5:23 ` Junio C Hamano
2017-06-23 16:53 ` Jeff King
2017-06-23 18:44 ` Junio C Hamano
2017-06-23 6:58 ` demerphq
2013-05-17 18:02 (unknown), ASHISH VERMA
2013-05-21 13:13 ` your mail Magnus Bäck
2012-05-06 14:17 (unknown), Bruce Zu
2012-05-06 17:04 ` your mail Marcus Karlsson
2008-08-13 14:54 (unknown), aneesh.kumar
2008-08-13 15:16 ` your mail Aneesh Kumar K.V
2007-12-05 19:00 [PATCH 0/6] builtin-remote Johannes Schindelin
2007-12-05 19:00 ` (unknown) Johannes Schindelin
2007-12-05 19:01 ` your mail Johannes Schindelin
2007-10-13 4:01 (unknown), Michael Witten
2007-10-13 4:07 ` your mail Jeff King
2006-11-21 22:24 (unknown) Johannes Schindelin
2006-11-22 20:16 ` your mail Davide Libenzi
2006-10-20 14:24 (unknown) andyparkins
2006-10-20 14:42 ` your mail Johannes Schindelin
[not found] <C8DBC54F2A9BAD4FA7F445CC7ADD963B0232474F@sslmexchange1.paymentech.us>
2006-09-26 19:56 ` Linus Torvalds
2006-05-21 23:53 (unknown) J. Bruce Fields
2006-05-21 23:55 ` your mail J. Bruce Fields
2006-05-22 0:16 ` Junio C Hamano
2006-05-22 1:33 ` J. Bruce Fields
2005-10-05 6:10 (unknown), Willem Swart
2005-10-06 10:52 ` your mail Elfyn McBratney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160411191311.GA9057@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=miwilliams@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).