From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Tim Schumacher <timschumi@gmx.de>,
gitster@pobox.com, pclouds@gmail.com
Subject: Re: ordered string-list considered harmful, was Re: [PATCH v3] Allow aliases that include other aliases
Date: Thu, 6 Sep 2018 16:50:33 -0700 [thread overview]
Message-ID: <20180906235033.GA100309@aiede.svl.corp.google.com> (raw)
In-Reply-To: <20180906192021.GB26575@sigill.intra.peff.net>
Hi,
Jeff King wrote:
> But what I think is harmful is a _sorted_ list, because of the
> "accidentally quadratic" nature, and because it's easy to call its
> functions on an unsorted list.
I agree --- in general, it tends to be better to build an unsorted
string list and then sort it.
Once I've done so, what is your advice about getting fast lookups
in the result? Should I build an auxiliary hashmap as well? Or
is this an argument for the 'sorted' flag + BUG approach you
already mentioned?
Whatever we do, I agree with your goal of getting rid of
string_list_insert.
Thanks,
Jonathan
next prev parent reply other threads:[~2018-09-06 23:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 19:12 ordered string-list considered harmful, was Re: [PATCH v3] Allow aliases that include other aliases Jeff King
2018-09-06 19:20 ` Jeff King
2018-09-06 23:50 ` Jonathan Nieder [this message]
2018-09-07 3:24 ` Jeff King
2018-09-07 6:32 ` Jonathan Nieder
2018-09-07 7:20 ` Ævar Arnfjörð Bjarmason
2018-09-07 7:23 ` Jonathan Nieder
2018-09-08 16:49 ` brian m. carlson
2018-09-07 14:48 ` Jeff King
2018-09-06 20:04 ` Stefan Beller
2018-09-06 20:49 ` Jeff King
2018-09-06 20:54 ` Stefan Beller
2018-09-07 3:12 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180906235033.GA100309@aiede.svl.corp.google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=timschumi@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).