git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] ci/config: correct instruction for CI preferences
Date: Mon, 18 May 2020 11:42:16 -0400	[thread overview]
Message-ID: <20200518154216.GA41356@coredump.intra.peff.net> (raw)
In-Reply-To: <20200518145234.20424-1-congdanhqx@gmail.com>

On Mon, May 18, 2020 at 09:52:34PM +0700, Đoàn Trần Công Danh wrote:

> From e76eec3554 (ci: allow per-branch config for GitHub Actions,
> 2020-05-07), we started to allow contributors decide which branch
> they want to build with GitHub Actions
> by checking for a file named "ci/config/allow-ref".
> 
> In order to assist those contributors,
> we provided a sample in "ci/config/allow-refs.sample",
> and instructed them to drop the ".sample",
> then commit that file to their repository.
> 
> We've misspelt the filename in that change.
> Let's fix the spelling.
> 
> While we're at it, also instruct our contributors introduce that new
> file to Git before commit, in case of they've never told Git before.
> 
> Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
> ---
> 
> This is a merge from:
> <20200508180047.GD637136@coredump.intra.peff.net>
> <20200509012304.GB2111@danh.dev>
> 
> It's slipped over the crack.

Yep, looks good. thanks for tying up this loose end.

> Hence, it may need Peff's SoB.
> Cc: Jeff King <peff@peff.net>

Signed-off-by: Jeff King <peff@peff.net>

-Peff

      reply	other threads:[~2020-05-18 15:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-18 14:52 [PATCH] ci/config: correct instruction for CI preferences Đoàn Trần Công Danh
2020-05-18 15:42 ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200518154216.GA41356@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=congdanhqx@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).