From: Atharva Raykar <raykar.ath@gmail.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git <git@vger.kernel.org>,
Shourya Shukla <shouryashukla.oo@gmail.com>,
Prathamesh Chavan <pc44800@gmail.com>
Subject: Re: [PATCH][GSoC] submodule: introduce add-clone helper for submodule add
Date: Wed, 2 Jun 2021 13:48:50 +0530 [thread overview]
Message-ID: <44C3C05A-1BA8-42BF-8614-1BA859050AEE@gmail.com> (raw)
In-Reply-To: <38AEA0B4-FCF7-4123-9412-98C1394972B0@gmail.com>
> On 02-Jun-2021, at 13:25, Atharva Raykar <raykar.ath@gmail.com> wrote:
>
> [...]
> I've not yet fully developed a taste for good C style, so I wanted
> to ask, which one looks better to you in these?
>
> /* Sample 1 */
> while (begin != end && (line = get_next_line(begin, end))) {
> char *name, *url, *tail;
> name = parse_token(&begin, next_line);
> url = parse_token(&begin, next_line);
> tail = parse_token(&begin, next_line);
> ...
> }
>
> /* Sample 2 */
> while (begin != end && (line = get_next_line(begin, end))) {
> char *name = parse_token(&begin, next_line);
> char *url = parse_token(&begin, next_line);
> char *tail = parse_token(&begin, next_line);
> ...
> }
Also ignore the error here, assume: s/next_line/line/
(Anyway, my question was about style)
next prev parent reply other threads:[~2021-06-02 8:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 8:12 [PATCH][GSoC] submodule: introduce add-clone helper for submodule add Atharva Raykar
2021-06-01 22:10 ` Christian Couder
2021-06-02 7:55 ` Atharva Raykar
2021-06-02 8:18 ` Atharva Raykar [this message]
2021-06-02 13:12 ` [PATCH v2] [GSoC] submodule--helper: introduce add-clone subcommand Atharva Raykar
2021-06-04 8:21 ` Christian Couder
2021-06-04 9:47 ` Atharva Raykar
2021-06-04 11:05 ` [PATCH v3] " Atharva Raykar
2021-06-04 11:16 ` Atharva Raykar
2021-06-04 11:37 ` [PATCH v2] " Shourya Shukla
2021-06-04 12:02 ` Atharva Raykar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44C3C05A-1BA8-42BF-8614-1BA859050AEE@gmail.com \
--to=raykar.ath@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=pc44800@gmail.com \
--cc=shouryashukla.oo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).