From: "Torsten Bögershausen" <tboegi@web.de>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH 3/4] drop some obsolete "x = x" compiler warning hacks
Date: Sun, 24 Mar 2013 08:17:26 +0100 [thread overview]
Message-ID: <514EA886.3090801@web.de> (raw)
In-Reply-To: <20130321204709.GL29311@google.com>
On 21.03.13 21:47, Jonathan Nieder wrote:
> Jeff King wrote:
>
>> And 4.3 was old enough for me to say "I do not care if you can run with
>> -Wall -Werror or not", let alone 4.2.
>
> Changes like this can only reveal bugs (in git or optimizers) that
> were hidden before, without regressing actual runtime behavior, so for
> what it's worth I like them.
>
> I think perhaps we should encourage people to use
> -Wno-error=uninitialized, in addition to cleaning up our code where
> reasonably recent optimizers reveal it to be confusing.
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
I got 2 warnings, but reading the comments I feel that
Mac OS 10.6 and i686-apple-darwin10-gcc-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5666) (dot 3)
is outdated ;-)
builtin/cat-file.c: In function ~cmd_cat_file~:
builtin/cat-file.c:196: warning: ~contents~ may be used uninitialized in this function
builtin/cat-file.c:196: note: ~contents~ was declared here
fast-import.c: In function ‘parse_new_commit’:
fast-import.c:2438: warning: ‘oe’ may be used uninitialized in this function
fast-import.c:2438: note: ‘oe’ was declared here
next prev parent reply other threads:[~2013-03-24 7:18 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 11:03 [PATCH 0/4] drop some "int x = x" hacks to silence gcc warnings Jeff King
2013-03-21 11:05 ` [PATCH 1/4] wt-status: fix possible use of uninitialized variable Jeff King
2013-03-21 19:49 ` Jonathan Nieder
2013-03-21 19:55 ` Junio C Hamano
2013-03-21 19:58 ` Jonathan Nieder
2013-03-22 16:15 ` Jeff King
2013-03-21 11:08 ` [PATCH 2/4] fast-import: use pointer-to-pointer to keep list tail Jeff King
2013-03-21 20:43 ` Jonathan Nieder
2013-03-21 11:10 ` [PATCH 3/4] drop some obsolete "x = x" compiler warning hacks Jeff King
2013-03-21 15:16 ` Erik Faye-Lund
2013-03-21 20:47 ` Jonathan Nieder
2013-03-24 7:17 ` Torsten Bögershausen [this message]
2013-03-21 11:13 ` [PATCH 4/4] transport: drop "int cmp = cmp" hack Jeff King
2013-03-21 20:59 ` Jonathan Nieder
2013-03-24 4:00 ` Junio C Hamano
2013-03-24 9:32 ` Jeff King
2013-03-24 14:54 ` Torsten Bögershausen
2013-03-25 19:50 ` Junio C Hamano
2013-03-25 21:06 ` Jeff King
2013-03-25 21:55 ` Junio C Hamano
2013-03-21 11:45 ` [PATCH 0/4] drop some "int x = x" hacks to silence gcc warnings Johannes Sixt
2013-03-21 11:55 ` Jeff King
2013-03-21 14:58 ` Junio C Hamano
2013-03-21 15:19 ` Junio C Hamano
2013-03-21 15:44 ` Jeff King
2013-03-21 15:44 ` [PATCH 5/4] fast-import: clarify "inline" logic in file_change_m Jeff King
2013-03-21 15:45 ` [PATCH 6/4] run-command: always set failed_errno in start_command Jeff King
2013-03-21 21:02 ` [PATCH 0/4] drop some "int x = x" hacks to silence gcc warnings Jonathan Nieder
2013-03-22 16:18 ` Jeff King
2013-03-22 16:19 ` [PATCH 7/4] submodule: clarify logic in show_submodule_summary Jeff King
2013-03-22 21:10 ` Junio C Hamano
2013-03-22 16:21 ` [PATCH 8/4] match-trees: drop "x = x" initializations Jeff King
2013-03-22 21:26 ` Junio C Hamano
2013-03-22 21:33 ` Junio C Hamano
2013-03-22 21:36 ` Jeff King
2013-03-23 18:57 ` René Scharfe
2013-03-24 4:55 ` Junio C Hamano
2013-03-24 10:01 ` Jeff King
2013-03-24 22:46 ` René Scharfe
2013-03-25 16:10 ` Junio C Hamano
2013-03-21 13:44 ` [PATCH 0/4] drop some "int x = x" hacks to silence gcc warnings Joachim Schmitz
2013-03-21 13:56 ` Joachim Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514EA886.3090801@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).