From: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
To: Jeff King <peff@peff.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 1/1] vreportf(): avoid relying on stdio buffering
Date: Tue, 29 Oct 2019 21:24:54 +0100 [thread overview]
Message-ID: <56f1bb8c-c4dc-4537-b42b-e728d2f2df19@syntevo.com> (raw)
In-Reply-To: <20191029200936.GA12337@sigill.intra.peff.net>
On 29.10.2019 21:09, Jeff King wrote:
> I think the issue is not the comparison, but rather that forming the
> pointer "msg + off" is undefined, since its point outside of any object
> (including the "one past" rule). And this is illegal in both C and C++,
Yes, thanks for clarifying.
> + p = msg + off < pend ? msg + off : pend - 1;
> though of course it works fine in practice most of the time.
The easiest thing that an optimizer can do (and that's actually quite
likely in my understanding) is to conclude that 'msg + off' is the only
non-UB branch here, therefore 'msg + off < pend' can be taken as always
true, and then discard 'pend - 1' branch. Afterall, UB serve the biggest
role in optimizations.
That's even more true now that all parts of equation are local and easy
to grasp for static analysis.
next prev parent reply other threads:[~2019-10-29 20:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 15:00 [PATCH 0/1] Fix t5516 flakiness in Visual Studio builds Johannes Schindelin via GitGitGadget
2019-10-28 15:00 ` [PATCH 1/1] vreportf(): avoid buffered write in favor of unbuffered one Johannes Schindelin via GitGitGadget
2019-10-29 3:18 ` Junio C Hamano
2019-10-29 12:30 ` Johannes Schindelin
2019-10-29 13:49 ` Jeff King
2019-10-29 14:13 ` Johannes Schindelin
2019-10-29 14:32 ` Jeff King
2019-10-29 20:09 ` Johannes Schindelin
2019-10-30 1:43 ` Junio C Hamano
2019-10-29 16:44 ` Junio C Hamano
2019-10-29 10:38 ` SZEDER Gábor
2019-10-29 12:38 ` Johannes Schindelin
2019-10-29 13:52 ` Jeff King
2019-10-29 14:18 ` Johannes Schindelin
2019-10-29 13:37 ` [PATCH v2 0/1] Fix t5516 flakiness in Visual Studio builds Johannes Schindelin via GitGitGadget
2019-10-29 13:37 ` [PATCH v2 1/1] vreportf(): avoid relying on stdio buffering Johannes Schindelin via GitGitGadget
2019-10-29 14:21 ` Alexandr Miloslavskiy
2019-10-29 19:57 ` Johannes Schindelin
2019-10-29 20:09 ` Jeff King
2019-10-29 20:24 ` Alexandr Miloslavskiy [this message]
2019-10-29 20:11 ` Alexandr Miloslavskiy
2019-10-29 20:01 ` [PATCH v3 0/1] Fix t5516 flakiness in Visual Studio builds Johannes Schindelin via GitGitGadget
2019-10-29 20:01 ` [PATCH v3 1/1] vreportf(): avoid relying on stdio buffering Johannes Schindelin via GitGitGadget
2019-10-29 20:32 ` Jeff King
2019-10-30 8:54 ` Johannes Schindelin
2019-10-31 6:24 ` Jeff King
2019-10-31 10:26 ` Johannes Schindelin
2019-10-31 15:48 ` Jeff King
2019-11-01 18:41 ` Johannes Schindelin
2019-10-30 2:01 ` Junio C Hamano
2019-10-30 9:13 ` Johannes Schindelin
2019-10-30 10:44 ` [PATCH v4 0/1] Fix t5516 flakiness in Visual Studio builds Johannes Schindelin via GitGitGadget
2019-10-30 10:44 ` [PATCH v4 1/1] vreportf(): avoid relying on stdio buffering Johannes Schindelin via GitGitGadget
2019-11-02 4:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56f1bb8c-c4dc-4537-b42b-e728d2f2df19@syntevo.com \
--to=alexandr.miloslavskiy@syntevo.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).