From: Felipe Contreras <felipe.contreras@gmail.com>
To: "Martin Ågren" <martin.agren@gmail.com>,
"Felipe Contreras" <felipe.contreras@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>, Jeff King <peff@peff.net>,
"brian m . carlson" <sandals@crustytoothpaste.net>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 8/8] doc: join xml and man rules
Date: Thu, 13 May 2021 06:15:52 -0500 [thread overview]
Message-ID: <609d0a684ece6_271c20831@natae.notmuch> (raw)
In-Reply-To: <CAN0heSrWu462h9Ch5K-aMHUgjB-BGqRp9YpWa=vPi_V+MiUwBg@mail.gmail.com>
Martin Ågren wrote:
> On Thu, 13 May 2021 at 00:28, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
> >
> > Will be useful later with asciidoctor that can do both at the same time.
>
> > -%.1 %.5 %.7 : %.xml manpage-base-url.xsl $(wildcard manpage*.xsl)
> > - $(QUIET_XMLTO)$(XMLTO) -m $(MANPAGE_XSL) $(XMLTO_EXTRA) man $<
> > -
> > -%.xml : %.txt $(ASCIIDOC_DEPS)
> > - $(QUIET_ASCIIDOC)$(TXT_TO_XML) -d manpage -o $@ $<
> > +%.1 %.5 %.7 : %.txt $(ASCIIDOC_DEPS) manpage-base-url.xsl $(wildcard manpage*.xsl)
> > + $(QUIET_ASCIIDOC)$(TXT_TO_XML) -d manpage -o $*.xml $< && \
> > + $(XMLTO) -m $(MANPAGE_XSL) $(XMLTO_EXTRA) man $*.xml
>
> It does mean that if manpage-base-url.xsl changes, we'll regenerate all
> the xml files. Before this change, we would just rerun the xmlto step.
True.
> Also, this will break `make info`.
Ahh, I didn't see that dependency on MAN_XML.
> (If you're wondering if anyone is actually using `make info`, there's
> some discussion at [1]. I don't think anyone would be too sad to see it
> go. Once `make info` is the only reason we need to generate the xml
> files, I think it's a given we should try to drop that stuff.)
Perhaps, but not in this patch series.
> I think we should keep the separate xml targets as long as "asciidoctor
> without xmlto" isn't the only way we support building the manpages. If
> the only benefit here is "later", I think we should do this patch later.
> I could also imagine that the xml target will just go away once all the
> "old" ways of building the manpages are gone and `make info` is gone,
> i.e., when we simply don't need any of these generated xml files.
Agreed. I will drop this in the next version.
Cheers.
--
Felipe Contreras
prev parent reply other threads:[~2021-05-13 11:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 22:27 [PATCH 0/8] doc: asciidoc cleanups Felipe Contreras
2021-05-12 22:27 ` [PATCH 1/8] doc: standardize asciidoc calls Felipe Contreras
2021-05-12 22:27 ` [PATCH 2/8] doc: add an asciidoc helper Felipe Contreras
2021-05-13 15:17 ` Ævar Arnfjörð Bjarmason
2021-05-13 19:33 ` Felipe Contreras
2021-05-13 21:43 ` Junio C Hamano
2021-05-12 22:27 ` [PATCH 3/8] doc: disable asciidoc-helper for asciidoctor Felipe Contreras
2021-05-12 22:27 ` [PATCH 4/8] doc: simplify the handling of interruptions Felipe Contreras
2021-05-13 5:19 ` Junio C Hamano
2021-05-13 6:10 ` Felipe Contreras
2021-05-12 22:28 ` [PATCH 5/8] doc: remove redundant rm Felipe Contreras
2021-05-13 15:22 ` Ævar Arnfjörð Bjarmason
2021-05-13 18:58 ` Felipe Contreras
2021-05-12 22:28 ` [PATCH 6/8] doc: refactor common dependencies Felipe Contreras
2021-05-12 22:28 ` [PATCH 7/8] doc: improve asciidoc dependencies Felipe Contreras
2021-05-13 17:43 ` Martin Ågren
2021-05-12 22:28 ` [PATCH 8/8] doc: join xml and man rules Felipe Contreras
2021-05-13 11:02 ` Martin Ågren
2021-05-13 11:15 ` Felipe Contreras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=609d0a684ece6_271c20831@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.agren@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).