From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Han-Wen Nienhuys <hanwen@google.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Sep 2021, #01; Thu, 2)
Date: Tue, 07 Sep 2021 00:21:28 +0200 [thread overview]
Message-ID: <87h7exnxzh.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <xmqq4kaxe5dt.fsf@gitster.g>
On Mon, Sep 06 2021, Junio C Hamano wrote:
> Han-Wen Nienhuys <hanwen@google.com> writes:
>
>> On Fri, Sep 3, 2021 at 12:48 AM Junio C Hamano <gitster@pobox.com> wrote:
>>> * hn/reftable (2021-08-26) 29 commits
>>> - SQUASH??? https://github.com/git/git/runs/3439941236?check_suite_focus=true#step:5:700
>>> - reftable: fixup for new base topic 3/3
>>> - reftable: fixup for new base topic 2/3
>>> - reftable: fixup for new base topic 1/3
>> ..
>>> The "reftable" backend for the refs API.
>>
>> I posted a subset of these patches as
>> https://lore.kernel.org/git/pull.1081.git.git.1630335476.gitgitgadget@gmail.com/
>
> Thanks for a ping. I saw it but haven't read it.
>
>> As discussed with AEvar, it will probably speed things up if we can
>> focus on getting the base library submitted without hooking it up to
>> Git. This would avoid cross-interactions with other pending topics,
>> and reduce the size of the more controversial topic (hooking it up to
>> Git).
>
> My worry is that a "base library" that is not hooked up to anything
> that works in the system would not be properly reviewed at all. Of
> course, without review, it would speed things up, but it is unclear
> if that the kind of speed we want.
>
> Anyway, I'll eject the old topic and replace them with the latest
> one soonish.
The proposal is to still have it hooked up to t/helper/test-reftable.c,
the build system, and t0032-reftable-unittest.sh.
So we'd build and test it on all platforms, getting that working in some
stable fashion would already be a big step forward.
What we wouldn't get right away is the series as of things like
0a0d5fe74d4 (refs: RFC: Reftable support for git-core, 2021-08-17),
i.e. hooking up refs/reftable-backend.c, changes to refs.[ch], running
reftable with some mode of "git init".
As discussed elsewhere that step would currently fail with some tests
failing, but most/all of those failures are due to the integration of
the reftable library into git, not failings of the library itself or the
reftable format.
next prev parent reply other threads:[~2021-09-06 22:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 22:48 What's cooking in git.git (Sep 2021, #01; Thu, 2) Junio C Hamano
2021-09-03 0:59 ` Philippe Blain
2021-09-03 4:38 ` Junio C Hamano
2021-09-03 2:25 ` Taylor Blau
2021-09-03 4:38 ` Junio C Hamano
2021-09-06 8:55 ` Carlo Arenas
2021-09-06 10:02 ` Ævar Arnfjörð Bjarmason
2021-09-06 21:52 ` Junio C Hamano
2021-09-07 17:39 ` Junio C Hamano
2021-09-06 10:36 ` Han-Wen Nienhuys
2021-09-06 21:55 ` Junio C Hamano
2021-09-06 22:21 ` Ævar Arnfjörð Bjarmason [this message]
2021-09-07 10:13 ` Ævar Arnfjörð Bjarmason
2021-09-07 17:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7exnxzh.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hanwen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).