From: Duy Nguyen <pclouds@gmail.com>
To: Elijah Newren <newren@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] merge-recursive: remove superfluous semicolon
Date: Wed, 5 Sep 2018 18:54:55 +0200 [thread overview]
Message-ID: <CACsJy8Cf5+3+6yDwe4Y4wYLze4Y6naW-pj134KTpXM+wyWbFVQ@mail.gmail.com> (raw)
In-Reply-To: <20180905164753.22711-1-newren@gmail.com>
On Wed, Sep 5, 2018 at 6:49 PM Elijah Newren <newren@gmail.com> wrote:
>
> Signed-off-by: Elijah Newren <newren@gmail.com>
> ---
> Once I saw it, I couldn't unsee it, and it quickly started getting on my
> nerves...
Bad Elijah! Should have grepped and fixed all three ;-)
$ git grep ';;$' -- '*.c'
builtin/receive-pack.c: hmac_sha1(sha1, buf.buf, buf.len,
cert_nonce_seed, strlen(cert_nonce_seed));;
merge-recursive.c: struct dir_rename_entry *entry = NULL;;
remote-curl.c: options.filter = xstrdup(value);;
>
> merge-recursive.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/merge-recursive.c b/merge-recursive.c
> index e5243dbc54..1b5c255918 100644
> --- a/merge-recursive.c
> +++ b/merge-recursive.c
> @@ -2239,7 +2239,7 @@ static struct dir_rename_entry *check_dir_renamed(const char *path,
> {
> char *temp = xstrdup(path);
> char *end;
> - struct dir_rename_entry *entry = NULL;;
> + struct dir_rename_entry *entry = NULL;
>
> while ((end = strrchr(temp, '/'))) {
> *end = '\0';
> --
> 2.19.0.rc2.1.g7fc77f67e1
>
--
Duy
next prev parent reply other threads:[~2018-09-05 16:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 16:47 [PATCH] merge-recursive: remove superfluous semicolon Elijah Newren
2018-09-05 16:54 ` Duy Nguyen [this message]
2018-09-05 17:03 ` Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8Cf5+3+6yDwe4Y4wYLze4Y6naW-pj134KTpXM+wyWbFVQ@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).