From: Han-Wen Nienhuys <hanwen@google.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Jeff King" <peff@peff.net>,
"Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
git@vger.kernel.org
Subject: Re: Giving priority to the reftable topic (was Re: What's cooking in git.git (Aug 2021, #06; Mon, 16))
Date: Thu, 7 Oct 2021 19:27:01 +0200 [thread overview]
Message-ID: <CAFQ2z_N6+cCSD=h989K=W+EF-PPmfx8E=j4zPLma2kXrSKsK=A@mail.gmail.com> (raw)
In-Reply-To: <bc387e32-321e-4726-2a02-2e6cf6ed5250@ramsayjones.plus.com>
On Sat, Aug 21, 2021 at 12:08 AM Ramsay Jones
<ramsay@ramsayjones.plus.com> wrote:
> Just a gentle reminder that this topic tickles my 'static-check.pl'
> script, like so:
>
> $ diff nsc ssc
> ...
> 88a91,98
> > reftable/generic.o - reftable_table_seek_log
> > reftable/merged.o - reftable_merged_table_hash_id
> > reftable/merged.o - reftable_merged_table_min_update_index
> > reftable/merged.o - reftable_merged_table_seek_log_at
> > reftable/publicbasics.o - reftable_set_alloc
> > reftable/reader.o - reader_seek
> > reftable/reader.o - reftable_reader_seek_log_at
> > reftable/stack.o - reftable_stack_auto_compact
> ...
> $
>
> Which is to say, all of the above symbols are defined (and called) in
> the '.c' file corresponding to the given object file, but not called
> anywhere outside that file. I have not even looked at those functions,
> but (with the possible exception of reftable_set_alloc()) they don't
> strike me as 'public API functions'. So, maybe they should be marked
> as 'static'?
They're all public except reader_seek().
I added some more coverage, in v4 of the library topic.
--
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--
Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
next prev parent reply other threads:[~2021-10-07 17:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 23:06 What's cooking in git.git (Aug 2021, #06; Mon, 16) Junio C Hamano
2021-08-16 23:43 ` Azeem Bande-Ali
2021-08-17 16:39 ` Junio C Hamano
2021-08-17 10:20 ` Phillip Wood
2021-08-17 17:00 ` Philippe Blain
2021-08-17 19:40 ` Junio C Hamano
[not found] ` <20210817193255.e7-9qhD5EZyGJNFbpSx2zPp6pXXRq5aMFbInG-_RoCk@z>
2021-08-17 19:32 ` Junio C Hamano
2021-08-17 17:12 ` Derrick Stolee
2021-08-18 5:15 ` Eric Sunshine
2021-08-19 10:06 ` Phillip Wood
2021-08-17 21:48 ` Junio C Hamano
2021-08-19 18:55 ` Phillip Wood
2021-08-19 19:38 ` Junio C Hamano
2021-08-20 6:09 ` Giving priority to the reftable topic (was Re: What's cooking in git.git (Aug 2021, #06; Mon, 16)) Junio C Hamano
2021-08-20 22:08 ` Ramsay Jones
2021-10-07 17:27 ` Han-Wen Nienhuys [this message]
[not found] ` <CACBZZX41gwo=pv_4fn2VcLz0Qq7Av-CWsnNXfXSuzmwZnu-Q3w@mail.gmail.com>
2021-08-23 10:21 ` Ævar Arnfjörð Bjarmason
2021-08-21 8:17 Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFQ2z_N6+cCSD=h989K=W+EF-PPmfx8E=j4zPLma2kXrSKsK=A@mail.gmail.com' \
--to=hanwen@google.com \
--cc=avarab@gmail.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).