From: Stefan Beller <sbeller@google.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Jameson Miller <jamill@microsoft.com>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH 01/13] repository: introduce object parser field
Date: Wed, 2 May 2018 10:26:48 -0700 [thread overview]
Message-ID: <CAGZ79ka6p33W8msji9kFMaWGOuDzSyx=y0AFPaQSX_08AZSgag@mail.gmail.com> (raw)
In-Reply-To: <CACsJy8CgX6BME=EhiDBfMRzBOYDBNHE6Ouxv4fZC-GW7Rsi81Q@mail.gmail.com>
On Wed, May 2, 2018 at 10:17 AM, Duy Nguyen <pclouds@gmail.com> wrote:
> On Tue, May 1, 2018 at 11:33 PM, Stefan Beller <sbeller@google.com> wrote:
>> /*
>> - * Holds any information related to accessing the raw object content.
>> + * Holds any information needed to retrieve the raw content
>> + * of objects. The object_parser uses this to get object
>> + * content which it then parses.
>> */
>> struct raw_object_store *objects;
>>
>> + /*
>> + * State for the object parser. This owns all parsed objects
>> + * (struct object) so callers do not have to manage their
>> + * lifetime.
>> + */
>> + struct object_parser *parsed_objects;
>
> I like this name 'parsed_objects'. Should we rename the struct after
> it (e.g. parsed_object_store as opposed to raw_object_store above)?
I can rename it to parsed_object_store for consistency.
> Another suggestion is object_pool, if we keep 'struct object' instead
> of 'struct parsed_object' and also want to keep current allocation
> behavior: no individual deallocation. If you free, you free the whole
> pool (e.g. you could run rev-list --all --objects in a separate pool,
> once you're done, you delete the whole pool).
That is what the following patches will be about, you can
only free the whole set of parsed objects.
So if you want to do a separate rev walk, you may need to
instantiate a new repository for it (ideally you'd only need a
separate parsed object store).
I'd want to have the ability to have separate pools for submodules,
such that they can be free'd on a per-repo basis.
> --
> Duy
next prev parent reply other threads:[~2018-05-02 17:26 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 21:33 [PATCH 00/13] object store: alloc Stefan Beller
2018-05-01 21:33 ` [PATCH 01/13] repository: introduce object parser field Stefan Beller
2018-05-02 17:17 ` Duy Nguyen
2018-05-02 17:26 ` Stefan Beller [this message]
2018-05-02 17:58 ` Duy Nguyen
2018-05-02 20:30 ` Jonathan Tan
2018-05-01 21:33 ` [PATCH 02/13] object: add repository argument to create_object Stefan Beller
2018-05-01 21:43 ` Eric Sunshine
2018-05-01 21:33 ` [PATCH 03/13] object: add repository argument to grow_object_hash Stefan Beller
2018-05-01 21:33 ` [PATCH 04/13] alloc: add repository argument to alloc_blob_node Stefan Beller
2018-05-02 20:34 ` Jonathan Tan
2018-05-01 21:33 ` [PATCH 05/13] alloc: add repository argument to alloc_tree_node Stefan Beller
2018-05-01 21:33 ` [PATCH 06/13] alloc: add repository argument to alloc_commit_node Stefan Beller
2018-05-01 21:33 ` [PATCH 07/13] alloc: add repository argument to alloc_tag_node Stefan Beller
2018-05-01 21:33 ` [PATCH 08/13] alloc: add repository argument to alloc_object_node Stefan Beller
2018-05-01 21:33 ` [PATCH 09/13] alloc: add repository argument to alloc_report Stefan Beller
2018-05-01 21:34 ` [PATCH 10/13] alloc: add repository argument to alloc_commit_index Stefan Beller
2018-05-01 21:34 ` [PATCH 11/13] object: allow grow_object_hash to handle arbitrary repositories Stefan Beller
2018-05-01 21:34 ` [PATCH 12/13] object: allow create_object " Stefan Beller
2018-05-02 20:36 ` Jonathan Tan
2018-05-01 21:34 ` [PATCH 13/13] alloc: allow arbitrary repositories for alloc functions Stefan Beller
2018-05-02 17:44 ` Duy Nguyen
2018-05-03 17:24 ` Stefan Beller
2018-05-03 17:35 ` Duy Nguyen
2018-05-02 20:50 ` Jonathan Tan
2018-05-03 17:25 ` Stefan Beller
2018-05-03 14:58 ` Duy Nguyen
2018-05-02 17:01 ` [PATCH 00/13] object store: alloc Duy Nguyen
2018-05-02 18:07 ` Jameson Miller
2018-05-02 18:22 ` Duy Nguyen
2018-05-02 18:44 ` Jameson Miller
2018-05-03 22:45 ` Stefan Beller
2018-05-07 14:05 ` Junio C Hamano
2018-05-07 20:53 ` Stefan Beller
2018-05-07 22:59 ` [PATCH v2 " Stefan Beller
2018-05-07 22:59 ` [PATCH v2 01/13] repository: introduce parsed objects field Stefan Beller
2018-05-08 17:23 ` Jonathan Tan
2018-05-07 22:59 ` [PATCH v2 02/13] object: add repository argument to create_object Stefan Beller
2018-05-07 22:59 ` [PATCH v2 03/13] object: add repository argument to grow_object_hash Stefan Beller
2018-05-07 22:59 ` [PATCH v2 04/13] alloc: add repository argument to alloc_blob_node Stefan Beller
2018-05-07 22:59 ` [PATCH v2 05/13] alloc: add repository argument to alloc_tree_node Stefan Beller
2018-05-07 22:59 ` [PATCH v2 06/13] alloc: add repository argument to alloc_commit_node Stefan Beller
2018-05-07 22:59 ` [PATCH v2 07/13] alloc: add repository argument to alloc_tag_node Stefan Beller
2018-05-07 22:59 ` [PATCH v2 08/13] alloc: add repository argument to alloc_object_node Stefan Beller
2018-05-07 22:59 ` [PATCH v2 09/13] alloc: add repository argument to alloc_report Stefan Beller
2018-05-07 22:59 ` [PATCH v2 10/13] alloc: add repository argument to alloc_commit_index Stefan Beller
2018-05-07 22:59 ` [PATCH v2 11/13] object: allow grow_object_hash to handle arbitrary repositories Stefan Beller
2018-05-07 22:59 ` [PATCH v2 12/13] object: allow create_object " Stefan Beller
2018-05-07 22:59 ` [PATCH v2 13/13] alloc: allow arbitrary repositories for alloc functions Stefan Beller
2018-05-08 10:10 ` Jeff King
2018-05-08 15:00 ` Duy Nguyen
2018-05-08 18:38 ` Stefan Beller
2018-05-08 17:45 ` Jonathan Tan
2018-05-08 19:37 ` [PATCH v3 00/13] object store: alloc Stefan Beller
2018-05-08 19:37 ` [PATCH v3 01/13] repository: introduce parsed objects field Stefan Beller
2018-05-08 19:37 ` [PATCH v3 02/13] object: add repository argument to create_object Stefan Beller
2018-05-08 19:37 ` [PATCH v3 03/13] object: add repository argument to grow_object_hash Stefan Beller
2018-05-08 19:37 ` [PATCH v3 04/13] alloc: add repository argument to alloc_blob_node Stefan Beller
2018-05-08 19:37 ` [PATCH v3 05/13] alloc: add repository argument to alloc_tree_node Stefan Beller
2018-05-08 19:37 ` [PATCH v3 06/13] alloc: add repository argument to alloc_commit_node Stefan Beller
2018-05-08 19:37 ` [PATCH v3 07/13] alloc: add repository argument to alloc_tag_node Stefan Beller
2018-05-08 19:37 ` [PATCH v3 08/13] alloc: add repository argument to alloc_object_node Stefan Beller
2018-05-08 19:37 ` [PATCH v3 09/13] alloc: add repository argument to alloc_report Stefan Beller
2018-05-08 19:37 ` [PATCH v3 10/13] alloc: add repository argument to alloc_commit_index Stefan Beller
2018-05-08 19:37 ` [PATCH v3 11/13] object: allow grow_object_hash to handle arbitrary repositories Stefan Beller
2018-05-08 19:37 ` [PATCH v3 12/13] object: allow create_object " Stefan Beller
2018-05-08 19:37 ` [PATCH v3 13/13] alloc: allow arbitrary repositories for alloc functions Stefan Beller
2018-05-08 20:04 ` Jonathan Tan
2018-05-08 20:37 ` Stefan Beller
2018-05-09 15:54 ` Duy Nguyen
2018-05-09 17:18 ` Duy Nguyen
2018-05-09 19:20 ` Stefan Beller
2018-05-10 15:43 ` Duy Nguyen
2018-05-10 0:40 ` [PATCH v4 00/13] object store: alloc Stefan Beller
2018-05-10 0:40 ` [PATCH v4 01/13] repository: introduce parsed objects field Stefan Beller
2018-05-10 0:40 ` [PATCH v4 02/13] object: add repository argument to create_object Stefan Beller
2018-05-10 0:40 ` [PATCH v4 03/13] object: add repository argument to grow_object_hash Stefan Beller
2018-05-10 0:40 ` [PATCH v4 04/13] alloc: add repository argument to alloc_blob_node Stefan Beller
2018-05-10 0:40 ` [PATCH v4 05/13] alloc: add repository argument to alloc_tree_node Stefan Beller
2018-05-10 0:40 ` [PATCH v4 06/13] alloc: add repository argument to alloc_commit_node Stefan Beller
2018-05-10 0:40 ` [PATCH v4 07/13] alloc: add repository argument to alloc_tag_node Stefan Beller
2018-05-10 0:40 ` [PATCH v4 08/13] alloc: add repository argument to alloc_object_node Stefan Beller
2018-05-10 0:40 ` [PATCH v4 09/13] alloc: add repository argument to alloc_report Stefan Beller
2018-05-10 0:40 ` [PATCH v4 10/13] alloc: add repository argument to alloc_commit_index Stefan Beller
2018-05-10 0:40 ` [PATCH v4 11/13] object: allow grow_object_hash to handle arbitrary repositories Stefan Beller
2018-05-10 0:40 ` [PATCH v4 12/13] object: allow create_object " Stefan Beller
2018-05-10 0:40 ` [PATCH v4 13/13] alloc: allow arbitrary repositories for alloc functions Stefan Beller
2018-05-10 17:16 ` [PATCH v4 00/13] object store: alloc Jonathan Tan
2018-05-10 17:32 ` Stefan Beller
2018-05-10 20:56 ` Jonathan Tan
2018-05-10 22:36 ` Stefan Beller
2018-05-11 19:17 ` [PATCH] alloc: allow arbitrary repositories for alloc functions Stefan Beller
2018-05-11 19:38 ` Eric Sunshine
2018-05-15 21:48 ` Stefan Beller
2018-05-16 2:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGZ79ka6p33W8msji9kFMaWGOuDzSyx=y0AFPaQSX_08AZSgag@mail.gmail.com' \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=jamill@microsoft.com \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).