From: Felipe Contreras <felipe.contreras@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>,
Emily Shaffer <emilyshaffer@google.com>,
"Brian M. Carlson" <sandals@crustytoothpaste.net>,
Aaron Schrab <aaron@schrab.com>,
Denton Liu <liu.denton@gmail.com>,
Christian Couder <christian.couder@gmail.com>
Subject: Re: [PATCH v2 1/2] Add project-wide .vimrc configuration
Date: Thu, 10 Dec 2020 18:43:18 -0600 [thread overview]
Message-ID: <CAMP44s2yBLD+4GTny-GxAuoUdg66zChebsKc=-V7AeOw+RTx-A@mail.gmail.com> (raw)
In-Reply-To: <X9I+eisn7sQuWZ1J@coredump.intra.peff.net>
On Thu, Dec 10, 2020 at 9:27 AM Jeff King <peff@peff.net> wrote:
>
> On Wed, Dec 09, 2020 at 07:55:55PM -0600, Felipe Contreras wrote:
>
> > > - t0 is specifying not to indent function return types when they
> > > appear on a separate line. But our style is not to put those return
> > > types on a separate line, anyway. Do we need this?
> >
> > Right. I recall at some point it was annoying me that types were auto
> > indented magically at wrong times. Testing "ts" that doesn't seem to
> > happen anymore, but it also doesn't seem to be working at all.
> >
> > Do you see some difference from "t0" and "ts" with:
> >
> > void
> > main(void) { }
>
> No, but picking it does seem to impact a larger example. If I open up
> wt-status.c and modify the first function to be:
>
> static const char *
> color(int slot, struct wt_status *s)
> {
>
> then reindenting it with t0 versus ts makes a difference (and I do
> prefer the t0 behavior).
I see.
For some reason this is indented:
void
main(void)
{
But not this:
void
main(void) {
> But we would not use that split-line style in
> our project in the first place, I don't think.
No, we don't use it, but I recall some problems when not setting it
(perhaps pasting code with that style).
Anyway, I can't reproduce any of the problems, so I'm fine with dropping it.
Cheers.
--
Felipe Contreras
next prev parent reply other threads:[~2020-12-11 0:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 6:55 [PATCH v2 0/2] vim: configuration and sharness syntax Felipe Contreras
2020-12-09 6:55 ` [PATCH v2 1/2] Add project-wide .vimrc configuration Felipe Contreras
2020-12-09 8:53 ` Christian Brabandt
2020-12-09 10:29 ` Felipe Contreras
2020-12-09 10:45 ` Christian Brabandt
2020-12-09 17:27 ` Jeff King
2020-12-10 1:55 ` Felipe Contreras
2020-12-10 15:27 ` Jeff King
2020-12-11 0:43 ` Felipe Contreras [this message]
2020-12-10 3:50 ` brian m. carlson
2020-12-11 1:08 ` Felipe Contreras
2020-12-11 2:56 ` brian m. carlson
2020-12-11 4:37 ` Felipe Contreras
2020-12-15 1:39 ` Jeff King
2020-12-15 3:03 ` Felipe Contreras
2020-12-15 5:28 ` Jeff King
2020-12-15 6:56 ` Felipe Contreras
2020-12-09 6:55 ` [PATCH v2 2/2] contrib: vim: add sharness syntax file Felipe Contreras
2020-12-09 7:05 ` Eric Sunshine
2020-12-09 10:39 ` Felipe Contreras
2020-12-09 17:11 ` [PATCH v2 0/2] vim: configuration and sharness syntax Jeff King
2020-12-10 3:25 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMP44s2yBLD+4GTny-GxAuoUdg66zChebsKc=-V7AeOw+RTx-A@mail.gmail.com' \
--to=felipe.contreras@gmail.com \
--cc=aaron@schrab.com \
--cc=christian.couder@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).