From: ZheNing Hu <adlternative@gmail.com>
To: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Cc: ZheNing Hu via GitGitGadget <gitgitgadget@gmail.com>,
Git List <git@vger.kernel.org>,
"Bradley M. Kuhn" <bkuhn@sfconservancy.org>,
Junio C Hamano <gitster@pobox.com>,
Brandon Casey <drafnel@gmail.com>,
Shourya Shukla <periperidip@gmail.com>,
Christian Couder <christian.couder@gmail.com>,
Rafael Silva <rafaeloliveira.cs@gmail.com>
Subject: Re: [PATCH v10 2/3] interpret-trailers: add own-identity option
Date: Fri, 19 Mar 2021 16:04:02 +0800 [thread overview]
Message-ID: <CAOLTT8R-h5T4eqZ_T1BFXX++u_A=2uhOhdfc4Yz83effhWjeqg@mail.gmail.com> (raw)
In-Reply-To: <YFODnm4JKfqRn37H@danh.dev>
Đoàn Trần Công Danh <congdanhqx@gmail.com> 于2021年3月19日周五 上午12:45写道:
>
> On 2021-03-18 11:15:55+0000, ZheNing Hu via GitGitGadget <gitgitgadget@gmail.com> wrote:
> > From: ZheNing Hu <adlternative@gmail.com>
> >
> > Beacuse `git commit --trailer="Signed-off-by: \
>
> s/Beacuse/Because/
>
> And I think, it's easier to read if we write the command in its own
> (indented) line.
>
> > $(git config user.name) <$(git config user.email)>"`
> > is difficult for users to add their own identities,
> > so teach interpret-trailers a new option `--own-identity`
> > which allow those trailers with no value add the user’s own
> > identity. This will help the use of `commit --trailer` as
> > easy as `--signoff`.
>
> Perhap, saying that we're optionalise <value> in --trailer, by
> substitute user's identity if missing instead?
Indeed so.
>
> > @@ -131,6 +144,7 @@ OPTIONS
> > when you know your input contains just the commit message itself
> > (and not an email or the output of `git format-patch`).
> >
> > +
>
> I think it's better to not add this line change
>
> > CONFIGURATION VARIABLES
> > -----------------------
> >
> > diff --git a/builtin/interpret-trailers.c b/builtin/interpret-trailers.c
> > index 84748eafc01b..be7f502a58d7 100644
> > --- a/builtin/interpret-trailers.c
> > +++ b/builtin/interpret-trailers.c
>
Thanks for these kindful advices.
> --
> Danh
--
ZheNing Hu
next prev parent reply other threads:[~2021-03-19 8:04 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 7:16 [PATCH] [GSOC] commit: provides multiple common signatures ZheNing Hu via GitGitGadget
2021-03-11 15:03 ` Shourya Shukla
2021-03-12 11:41 ` ZheNing Hu
2021-03-11 17:28 ` Junio C Hamano
2021-03-12 12:01 ` ZheNing Hu
2021-03-12 13:22 ` ZheNing Hu
2021-03-12 15:54 ` [PATCH v2] [GSOC] commit: add trailer command ZheNing Hu via GitGitGadget
2021-03-14 4:19 ` Christian Couder
2021-03-14 7:09 ` ZheNing Hu
2021-03-14 22:45 ` Junio C Hamano
2021-03-14 13:02 ` [PATCH v3] [GSOC] commit: add --trailer option ZheNing Hu via GitGitGadget
2021-03-14 13:10 ` Rafael Silva
2021-03-14 14:13 ` ZheNing Hu
2021-03-14 15:58 ` [PATCH v4] " ZheNing Hu via GitGitGadget
2021-03-14 23:52 ` Junio C Hamano
2021-03-15 1:27 ` ZheNing Hu
2021-03-15 4:42 ` Junio C Hamano
2021-03-15 5:14 ` ZheNing Hu
2021-03-15 3:24 ` [PATCH v5] " ZheNing Hu via GitGitGadget
2021-03-15 5:33 ` Christian Couder
2021-03-15 5:41 ` Christian Couder
2021-03-15 5:46 ` ZheNing Hu
2021-03-15 6:35 ` [PATCH v6] " ZheNing Hu via GitGitGadget
2021-03-15 8:02 ` Christian Couder
2021-03-15 8:21 ` ZheNing Hu
2021-03-15 9:08 ` [PATCH v7] " ZheNing Hu via GitGitGadget
2021-03-15 10:00 ` Christian Couder
2021-03-15 10:14 ` Christian Couder
2021-03-15 11:32 ` ZheNing Hu
2021-03-16 5:37 ` Christian Couder
2021-03-16 8:35 ` ZheNing Hu
2021-03-15 13:07 ` [PATCH v8 0/2] " ZheNing Hu via GitGitGadget
2021-03-15 13:07 ` [PATCH v8 1/2] " ZheNing Hu via GitGitGadget
2021-03-16 12:52 ` Ævar Arnfjörð Bjarmason
2021-03-17 2:01 ` ZheNing Hu
2021-03-17 8:08 ` Ævar Arnfjörð Bjarmason
2021-03-17 13:54 ` ZheNing Hu
2021-03-15 13:07 ` [PATCH v8 2/2] interpret_trailers: for three options parse add warning ZheNing Hu via GitGitGadget
2021-03-16 5:53 ` Christian Couder
2021-03-16 9:11 ` ZheNing Hu
2021-03-16 10:39 ` [PATCH v9] [GSOC] commit: add --trailer option ZheNing Hu via GitGitGadget
2021-03-17 5:26 ` Shourya Shukla
2021-03-17 6:06 ` ZheNing Hu
2021-03-18 11:15 ` [PATCH v10 0/3] " ZheNing Hu via GitGitGadget
2021-03-18 11:15 ` [PATCH v10 1/3] " ZheNing Hu via GitGitGadget
2021-03-18 16:29 ` Đoàn Trần Công Danh
2021-03-19 7:56 ` ZheNing Hu
2021-03-18 11:15 ` [PATCH v10 2/3] interpret-trailers: add own-identity option ZheNing Hu via GitGitGadget
2021-03-18 16:45 ` Đoàn Trần Công Danh
2021-03-19 8:04 ` ZheNing Hu [this message]
2021-03-18 19:20 ` Junio C Hamano
2021-03-19 9:33 ` ZheNing Hu
2021-03-19 15:36 ` Junio C Hamano
2021-03-20 2:54 ` ZheNing Hu
2021-03-20 5:06 ` Jeff King
2021-03-20 5:50 ` Junio C Hamano
2021-03-20 6:16 ` ZheNing Hu
2021-03-20 6:38 ` ZheNing Hu
2021-03-20 6:53 ` Junio C Hamano
2021-03-20 8:43 ` ZheNing Hu
2021-03-18 11:15 ` [PATCH v10 3/3] commit: " ZheNing Hu via GitGitGadget
2021-03-18 13:47 ` [PATCH v10 0/3] [GSOC] commit: add --trailer option Christian Couder
2021-03-18 15:27 ` ZheNing Hu
2021-03-19 12:05 ` [PATCH v11] " ZheNing Hu via GitGitGadget
2021-03-19 17:48 ` Junio C Hamano
2021-03-20 13:41 ` [PATCH v12] " ZheNing Hu via GitGitGadget
2021-03-22 4:24 ` [PATCH v13] " ZheNing Hu via GitGitGadget
2021-03-22 7:43 ` Christian Couder
2021-03-22 10:23 ` ZheNing Hu
2021-03-22 21:34 ` Christian Couder
2021-03-23 6:11 ` ZheNing Hu
2021-03-23 6:19 ` Junio C Hamano
2021-03-23 7:57 ` Christian Couder
2021-03-23 17:11 ` Junio C Hamano
2021-03-24 5:21 ` ZheNing Hu
2021-03-23 10:35 ` ZheNing Hu
2021-03-23 12:41 ` Christian Couder
2021-03-23 17:12 ` Junio C Hamano
2021-03-24 5:25 ` ZheNing Hu
2021-03-22 21:55 ` Christian Couder
2021-03-23 6:29 ` ZheNing Hu
2021-03-23 13:55 ` [PATCH v14] " ZheNing Hu via GitGitGadget
2021-03-15 4:38 ` [PATCH v4] " Junio C Hamano
2021-03-15 5:11 ` ZheNing Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOLTT8R-h5T4eqZ_T1BFXX++u_A=2uhOhdfc4Yz83effhWjeqg@mail.gmail.com' \
--to=adlternative@gmail.com \
--cc=bkuhn@sfconservancy.org \
--cc=christian.couder@gmail.com \
--cc=congdanhqx@gmail.com \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=periperidip@gmail.com \
--cc=rafaeloliveira.cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).