From: Eric Sunshine <sunshine@sunshineco.com>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git List <git@vger.kernel.org>,
Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH] t1450: fix quoting of NUL byte when corrupting pack
Date: Sun, 2 Aug 2020 13:22:02 -0400 [thread overview]
Message-ID: <CAPig+cR=AdRbJgnVBJsbEtNmV41bRDkXE-tyWsztoYF7jZKeAQ@mail.gmail.com> (raw)
In-Reply-To: <20200802143018.5501-1-martin.agren@gmail.com>
On Sun, Aug 2, 2020 at 10:30 AM Martin Ågren <martin.agren@gmail.com> wrote:
> Subject: [PATCH] t: don't spuriously close & open quotes
> [...]
> Signed-off-by: Martin Ågren <martin.agren@gmail.com>
> ---
> diff --git a/t/t7001-mv.sh b/t/t7001-mv.sh
> @@ -177,7 +177,7 @@ test_expect_success "Sergey Vlasov's test case" '
> git add ab.c ab &&
> - git commit -m 'initial' &&
> + git commit -m "initial" &&
> git mv ab a
> '
This was discovered[1] independently a couple weeks ago; glad to see
it was picked up by your grep'ing, as well.
[1]: https://lore.kernel.org/git/CAPig+cQpUu2UO-+jWn1nTaDykWnxwuEitzVB7PnW2SS_b7V8Hg@mail.gmail.com/
next prev parent reply other threads:[~2020-08-02 17:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-01 22:06 [PATCH] t1450: fix quoting of NUL byte when corrupting pack Martin Ågren
2020-08-02 0:45 ` Junio C Hamano
2020-08-02 14:30 ` Martin Ågren
2020-08-02 17:22 ` Eric Sunshine [this message]
2020-08-06 20:08 ` [PATCH v2 0/2] t: don't spuriously close and reopen quotes Martin Ågren
2020-08-06 20:08 ` [PATCH v2 1/2] " Martin Ågren
2020-08-06 20:26 ` Eric Sunshine
2020-08-07 8:45 ` Martin Ågren
2020-08-07 16:17 ` Eric Sunshine
2020-08-07 17:16 ` Junio C Hamano
2020-08-06 20:08 ` [PATCH v2 2/2] t4104: modernize and simplify quoting Martin Ågren
2020-08-02 1:00 ` [PATCH] t1450: fix quoting of NUL byte when corrupting pack Chris Torek
2020-08-02 1:02 ` Chris Torek
2020-08-02 14:35 ` Martin Ågren
2020-08-02 16:20 ` Chris Torek
2020-08-02 17:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cR=AdRbJgnVBJsbEtNmV41bRDkXE-tyWsztoYF7jZKeAQ@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=martin.agren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).