git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vadim Zeitlin <vz-git@zeitlins.org>
To: johannes.schindelin@gmx.de
Cc: git@vger.kernel.org
Subject: Re: [PATCH] fetch: allow running as different users in shared repositories
Date: Thu, 26 Mar 2020 01:44:23 +0100	[thread overview]
Message-ID: <E1jHGdD-00079b-06@smtp.tt-solutions.com> (raw)
In-Reply-To: nycvar.QRO.7.76.6.2003252001560.46@tvgsbejvaqbjf.bet

On Wed, 25 Mar 2020 20:04:09 +0100 Johannes Schindelin wrote:

JS> Hi Vadim,

 Hello Johannes and thanks for your reply!

JS> On Thu, 19 Mar 2020, Vadim Zeitlin wrote:
JS> 
JS> > The function fopen_for_writing(), which was added in 79d7582e32 (commit:
JS> > allow editing the commit message even in shared repos, 2016-01-06) and
JS> > used for overwriting FETCH_HEAD since ea56518dfe (Handle more file
JS> > writes correctly in shared repos, 2016-01-11), didn't do it correctly in
JS> > shared repositories under Linux.
JS> >
JS> > This happened because in this situation the file FETCH_HEAD has mode 644
JS> 
JS> I wonder why that is. In a shared repository, it should have mode 664, I
JS> thought.

 This file is created using a simple fopen("w") and so is subject to umask.
With the usual default umask value (022) its mode would be 644, regardless
of the repository settings.

[...snip my original description...]
JS> That rationale makes sense to me, as does the patch.

 Sorry for a possibly stupid question, but what is the next thing to do
now? The instructions in Documentation/SubmittingPatches indicate that I
should wait until the "list forms consensus that [...] your patch is good",
but it's not quite clear what indicates that a consensus has been reached.
Is your comment above enough or should I wait for something else? And
if/when it has been reached, do I really I need to resend the patch to
the maintainer and cc the list as written in that document? I'm a bit
surprised by this because I don't see (most) patches being resent to this
list.

 This is obviously very non-urgent, but I'd just like to understand what,
if anything, is expected from me.

 Thanks in advance for your guidance!
VZ

             reply	other threads:[~2020-03-26  1:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26  0:44 Vadim Zeitlin [this message]
2020-03-26 14:40 ` [PATCH] fetch: allow running as different users in shared repositories Johannes Schindelin
2020-03-26 22:32   ` Re[2]: " Vadim Zeitlin
2020-05-01 23:11   ` Vadim Zeitlin
2020-05-04 16:32     ` Junio C Hamano
2020-05-04 17:04       ` Re[2]: " Vadim Zeitlin
2020-05-04 20:39         ` Junio C Hamano
2020-05-05  0:08           ` Re[2]: " Vadim Zeitlin
  -- strict thread matches above, loose matches on Subject: below --
2020-03-19  1:03 Vadim Zeitlin
2020-03-25 19:04 ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1jHGdD-00079b-06@smtp.tt-solutions.com \
    --to=vz-git@zeitlins.org \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).