From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Jeffrey Walton <noloader@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: Git 2.31.1, Solaris and error: conflicting types for 'inet_ntop'
Date: Sun, 28 Mar 2021 01:26:10 +0000 [thread overview]
Message-ID: <YF/bMjJA2RguVguZ@camp.crustytoothpaste.net> (raw)
In-Reply-To: <CAH8yC8mSMZDjhbidruAh9t7QFsv6Yxqi1poNEXBT=Nn9+sB2hA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
On 2021-03-28 at 01:04:32, Jeffrey Walton wrote:
> I see what happened... I stopped Autoreconfing so the configure.ac
> changes were not picked up. The original configure is being used.
>
> I think Git is getting itself into that state.
>
> Without the Autoreconf, I was able to sidestep the issue with:
>
> if [[ "${IS_SOLARIS}" -eq 1 ]]; then
> CONFIG_OPTS+=("ac_cv_func_inet_ntop=yes")
> CONFIG_OPTS+=("ac_cv_func_inet_pton=yes")
> fi
Most developers don't use the autoconf stuff and just use the makefile.
config.mak.uname doesn't have NO_INET_NTOP set for SunOS.
If the autoconf scripts or config.mak.uname need fixing, which is
possible, a patch would definitely be welcome.
--
brian m. carlson (he/him or they/them)
Houston, Texas, US
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2021-03-28 1:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-28 0:18 Git 2.31.1, Solaris and error: conflicting types for 'inet_ntop' Jeffrey Walton
2021-03-28 0:45 ` brian m. carlson
2021-03-28 1:04 ` Jeffrey Walton
2021-03-28 1:26 ` brian m. carlson [this message]
2021-03-28 7:22 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YF/bMjJA2RguVguZ@camp.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=noloader@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).