From: Jonathan Nieder <jrnieder@gmail.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Johannes Schindelin" <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] t9001-send-email.sh: fix expected absolute paths on Windows
Date: Mon, 24 May 2021 13:26:06 -0700 [thread overview]
Message-ID: <YKwL3t8bKIh6LPsE@google.com> (raw)
In-Reply-To: <bb30fe2b-cd75-4782-24a6-08bb002a0367@kdbg.org>
Hi,
Johannes Sixt wrote:
> Git for Windows is a native Windows program that works with native
> absolute paths in the drive letter style C:\dir. The auxiliary
> infrastructure is based on MSYS2, which uses POSIX style /C/dir.
[nice explanation snipped]
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
> When I say "the configuration is transformed to /C/dir style", I am
> actually hand-waving: I can observe that a transformation must
> happen somewhere, but I actually do not know where the conversion
> really happens. "The MSYS2 layer" is my best qualified guess.
Thanks. The explanation is appreciated --- it helps avoid the feeling
of randomness involved. Hopefully some day our test setup will allow
doing everything at the "native Windows program" level (well, I can
hope).
[...]
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -539,15 +539,14 @@ test_expect_success $PREREQ "--validate respects relative core.hooksPath path" '
> test_path_is_file my-hooks.ran &&
> cat >expect <<-EOF &&
> fatal: longline.patch: rejected by sendemail-validate hook
> - fatal: command '"'"'$(pwd)/my-hooks/sendemail-validate'"'"' died with exit code 1
> + fatal: command '"'"'$PWD/my-hooks/sendemail-validate'"'"' died with exit code 1
> warning: no patches were sent
> EOF
> test_cmp expect actual
Ideally we wouldn't have to check the exact output at all. Is there a
reason we care about the absolute path being echoed on error?
[...]
> test_expect_success $PREREQ "--validate respects absolute core.hooksPath path" '
> - hooks_path="$(pwd)/my-hooks" &&
> - test_config core.hooksPath "$hooks_path" &&
> + test_config core.hooksPath "$(pwd)/my-hooks" &&
> test_when_finished "rm my-hooks.ran" &&
> test_must_fail git send-email \
> --from="Example <nobody@example.com>" \
> @@ -558,7 +557,7 @@ test_expect_success $PREREQ "--validate respects absolute core.hooksPath path" '
> test_path_is_file my-hooks.ran &&
> cat >expect <<-EOF &&
> fatal: longline.patch: rejected by sendemail-validate hook
> - fatal: command '"'"'$hooks_path/sendemail-validate'"'"' died with exit code 1
> + fatal: command '"'"'$PWD/my-hooks/sendemail-validate'"'"' died with exit code 1
> warning: no patches were sent
> EOF
> test_cmp expect actual
Likewise.
That said, the patch as is is
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
next prev parent reply other threads:[~2021-05-24 20:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 19:38 [PATCH] t9001-send-email.sh: fix expected absolute paths on Windows Johannes Sixt
2021-05-24 20:26 ` Jonathan Nieder [this message]
2021-05-24 22:15 ` Ævar Arnfjörð Bjarmason
2021-05-24 23:15 ` Ævar Arnfjörð Bjarmason
2021-05-24 23:14 ` [PATCH 0/2] send-email: pre-release fixes for v2.32.0 Ævar Arnfjörð Bjarmason
2021-05-24 23:14 ` [PATCH 1/2] send-email: fix missing error message regression Ævar Arnfjörð Bjarmason
2021-05-24 23:14 ` [PATCH 2/2] send-email: don't needlessly abs_path() the core.hooksPath Ævar Arnfjörð Bjarmason
2021-05-25 1:03 ` Junio C Hamano
2021-05-25 5:57 ` Ævar Arnfjörð Bjarmason
2021-05-25 6:13 ` Ævar Arnfjörð Bjarmason
2021-05-25 6:21 ` Robert Foss
2021-05-25 6:21 ` Junio C Hamano
2021-05-25 12:09 ` Ævar Arnfjörð Bjarmason
2021-05-25 19:28 ` Junio C Hamano
2021-05-26 11:21 ` [PATCH v2 0/2] " Ævar Arnfjörð Bjarmason
2021-05-26 11:21 ` [PATCH v2 1/2] " Ævar Arnfjörð Bjarmason
2021-05-26 11:21 ` [PATCH v2 2/2] send-email: move "hooks_path" invocation to git-send-email.perl Ævar Arnfjörð Bjarmason
2021-05-26 1:22 ` [PATCH 2/2] send-email: don't needlessly abs_path() the core.hooksPath Felipe Contreras
2021-05-25 6:10 ` Robert Foss
2021-06-02 11:40 ` [PATCH] t9001-send-email.sh: fix expected absolute paths on Windows Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKwL3t8bKIh6LPsE@google.com \
--to=jrnieder@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).