git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Taylor Blau <me@ttaylorr.com>
Cc: "Randall S. Becker" <rsbecker@nexbridge.com>,
	'Junio C Hamano' <gitster@pobox.com>,
	git@vger.kernel.org
Subject: Re: [ANNOUNCE] Git v2.32.0-rc3 - t5300 Still Broken on NonStop ia64/x86
Date: Wed, 2 Jun 2021 16:15:45 -0400	[thread overview]
Message-ID: <YLfm8cqY6EjQuhcO@coredump.intra.peff.net> (raw)
In-Reply-To: <YLfl4jkuwSCiNrrS@nand.local>

On Wed, Jun 02, 2021 at 04:11:14PM -0400, Taylor Blau wrote:

> Subject: [PATCH] compat: introduce git_fsync_with_restart()
> 
> Some platforms, like NonStop do not automatically restart fsync() when
> interrupted by a signal, even when that signal is setup with SA_RESTART.
> 
> This can lead to test breakage, e.g., where "--progress" is used, thus
> SIGALRM is sent often, and can interrupt an fsync() syscall.
> 
> Add a Makefile knob FSYNC_NEEDS_RESTART to replace fsync() with one that
> gracefully handles getting EINTR.
> 
> Reported-by: Randall S. Becker <randall.becker@nexbridge.ca>
> Signed-off-by: Jeff King <peff@peff.net>

Probably Helped-by might be more appropriate. But regardless, I
definitely give my S-o-B for anything I contributed.

>  Makefile          |  8 ++++++++
>  compat/fsync.c    | 10 ++++++++++
>  git-compat-util.h |  6 ++++++
>  3 files changed, 24 insertions(+)
>  create mode 100644 compat/fsync.c

This looks as I'd expect. But after seeing Eric's response, we perhaps
want to do away with the knob entirely.

-Peff

  reply	other threads:[~2021-06-02 20:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02 17:52 [ANNOUNCE] Git v2.32.0-rc3 - t5300 Still Broken on NonStop ia64/x86 Randall S. Becker
2021-06-02 19:32 ` Taylor Blau
2021-06-02 19:49   ` Jeff King
2021-06-02 20:11     ` Taylor Blau
2021-06-02 20:15       ` Jeff King [this message]
2021-06-02 20:36         ` Randall S. Becker
2021-06-04  1:36         ` Junio C Hamano
2021-06-04  2:17           ` Taylor Blau
2021-06-04  3:55           ` Jeff King
2021-06-04  5:12             ` Junio C Hamano
2021-06-06 19:06               ` Randall S. Becker
2021-06-08  6:40                 ` Jeff King
2021-06-05  7:04           ` René Scharfe
2021-06-05 13:15             ` Junio C Hamano
2021-06-02 20:11     ` Eric Wong
2021-06-02 20:14       ` Jeff King
2021-06-02 20:18         ` Taylor Blau
2021-06-02 20:34         ` Randall S. Becker
2021-06-03 19:31           ` Jeff King
2021-06-03 20:07             ` Randall S. Becker
2021-06-03 20:21         ` Bryan Turner
2021-06-03 20:32           ` Randall S. Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLfm8cqY6EjQuhcO@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=me@ttaylorr.com \
    --cc=rsbecker@nexbridge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).