From: Jeff King <peff@peff.net>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Bagas Sanjaya <bagasdotme@gmail.com>,
git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>,
Matthieu Moy <git@matthieu-moy.fr>,
Michael J Gruber <git@grubix.eu>
Subject: Re: [PATCH 6/7] stage: add 'diff' subcommand
Date: Wed, 11 Aug 2021 16:30:36 -0400 [thread overview]
Message-ID: <YRQzbPpk23dVqP+g@coredump.intra.peff.net> (raw)
In-Reply-To: <611430a5b83e1_19f82083b@natae.notmuch>
On Wed, Aug 11, 2021 at 03:18:45PM -0500, Felipe Contreras wrote:
> > One thing I find off-putting about "git stage --diff" is that to me,
> > "stage" reads as a verb. So it is like "git add --diff", which seems
> > out-of-place; there are two verbs in a row.
> >
> > I do not mind the term "staging area", but using "the stage" as a noun
> > is simply confusing to me in this context.
>
> OK, but "stage" can be a noun.
>
> Here is one of the definitions:
>
> : a center of attention or scene of action
>
> This definition doesn't imply what the action is about, but
> "commit stage" should be perfectly aligned with that definition.
>
> Here's another one:
>
> : one of two or more sections of a rocket that have their own fuel and engine
Sure, I know the various meanings of "stage" in English. But I do not find it a
synonym for "staging area" at all. Now my opinion may not matter, but:
- I thought the goal of using a different name was to find something
that made intuitive sense to English speakers. I do not find "the
stage" any better than "the index" (in fact, I find it worse).
- Part of your argument seems to be "many people expressed an opinion
that the term 'staging area' was a good idea". My name was among
them. But in the very email from which you quoted me, I am arguing
that "staging area" makes sense to me, but "the stage" does not.
-Peff
next prev parent reply other threads:[~2021-08-11 20:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 4:57 [PATCH 0/7] [un]stage: officially start moving to "staging area" Felipe Contreras
2021-08-11 4:57 ` [PATCH 1/7] stage: add proper 'stage' command Felipe Contreras
2021-08-11 4:57 ` [PATCH 2/7] stage: add helper to run commands Felipe Contreras
2021-08-11 4:57 ` [PATCH 3/7] stage: add 'add' subcommand Felipe Contreras
2021-08-11 4:57 ` [PATCH 4/7] stage: add 'remove' subcommand Felipe Contreras
2021-08-11 4:57 ` [PATCH 5/7] unstage: add 'unstage' command Felipe Contreras
2021-08-11 4:57 ` [PATCH 6/7] stage: add 'diff' subcommand Felipe Contreras
2021-08-11 6:12 ` Bagas Sanjaya
2021-08-11 7:24 ` Felipe Contreras
2021-08-11 16:00 ` Junio C Hamano
2021-08-11 17:17 ` Felipe Contreras
2021-08-11 19:06 ` Jeff King
2021-08-11 20:18 ` Felipe Contreras
2021-08-11 20:30 ` Jeff King [this message]
2021-08-11 21:24 ` Felipe Contreras
2021-08-11 20:19 ` Michael J Gruber
2021-08-11 20:40 ` Jeff King
2021-08-11 20:51 ` Michael J Gruber
2021-08-11 21:02 ` Jeff King
2021-08-11 20:57 ` Junio C Hamano
2021-08-11 21:40 ` Felipe Contreras
2021-08-11 4:57 ` [PATCH 7/7] stage: add 'edit' command Felipe Contreras
2021-08-11 10:44 ` [PATCH 0/7] [un]stage: officially start moving to "staging area" Michael J Gruber
2021-08-11 16:55 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRQzbPpk23dVqP+g@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=bagasdotme@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@grubix.eu \
--cc=git@matthieu-moy.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).