git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: ds/commit-graph-on-fetch (was Re: What's cooking in git.git (Oct 2019, #07; Wed, 30))
Date: Wed, 30 Oct 2019 08:39:26 -0400	[thread overview]
Message-ID: <afec0f94-466a-2901-4dd7-528d0ae587fa@gmail.com> (raw)
In-Reply-To: <xmqqd0ee3du9.fsf@gitster-ct.c.googlers.com>

On 10/30/2019 3:13 AM, Junio C Hamano wrote:
> Here are the topics that have been cooking.  Commits prefixed with
> '-' are only in 'pu' (proposed updates) while commits prefixed with
> '+' are in 'next'.  The ones marked with '.' do not appear in any of
> the integration branches, but I am still holding onto them.
> 
> There is the v2.24.0-rc2 tag now; the contents of the release
> candidate hasn't changed much since the -rc1; hopefully we can see
> the final thing real soon now.

[snip]

> * ds/commit-graph-on-fetch (2019-10-25) 2 commits
>   (merged to 'next' on 2019-10-30 at 3ca711f743)
>  + commit-graph: fix writing first commit-graph during fetch
>  + t5510-fetch.sh: demonstrate fetch.writeCommitGraph bug
> 
>  "git commit-grph write" hit BUG() in corner cases.

s/grph/graph/

>  Will cook in 'next'.

I had thought this bugfix was worthy of making the release, as it
may affect more users than I realized (anyone with a submodule, fetching
after first clone).

I understand if it is held back because it only affects a new feature
that is opt-in for this release (the fetch.writeCommitGraph setting).
Just wanted to check on the decision here.

Thanks,
-Stolee

  reply	other threads:[~2019-10-30 12:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-30  7:13 What's cooking in git.git (Oct 2019, #07; Wed, 30) Junio C Hamano
2019-10-30 12:39 ` Derrick Stolee [this message]
2019-11-02  6:13   ` ds/commit-graph-on-fetch (was Re: What's cooking in git.git (Oct 2019, #07; Wed, 30)) Junio C Hamano
2019-10-30 22:39 ` ds/commit-graph-on-fetch, was Re: What's cooking in git.git (Oct 2019, #07; Wed, 30) Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afec0f94-466a-2901-4dd7-528d0ae587fa@gmail.com \
    --to=stolee@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).