From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
John Goerzen <jgoerzen@complete.org>
Subject: Re: [RFH] bug in unpack_trees
Date: Tue, 4 Mar 2008 13:31:44 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.1.00.0803041325370.12253@woody.linux-foundation.org> (raw)
In-Reply-To: <20080304115940.GA5260@sigill.intra.peff.net>
On Tue, 4 Mar 2008, Jeff King wrote:
>
> I am tracking down a bug in unpack_trees, but I can't seem to find the
> exact problem; I'm hoping to get help from people who have touched this
> code a bit more than I have.
Ok, I haven't (the blame for that unpack_trees function lies mainly at
Dscho, I think ;), and now that I'm looking at it more closely I really
don't think unpack_trees() is salvageable.
I tried. I can't make it work.
The only really sane way to traverse trees in parallel is with the
walk-tree.c functionality (ie using "traverse_trees()"), which is quite
straightforward and rather simple, and which I can pretty much guarantee
works.
In contrast, the things that unpack_trees() does to try to figure out how
to mix in the index into the pot really doesn't work.
I'll take a good hard look at trying to convert users of unpack_trees()
into traverse_trees(), or perhaps even convert "unpack_trees()" itself.
Linus
next prev parent reply other threads:[~2008-03-04 21:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 11:59 [RFH] bug in unpack_trees Jeff King
2008-03-04 21:31 ` Linus Torvalds [this message]
2008-03-05 6:47 ` Daniel Barkalow
2008-03-05 15:56 ` Linus Torvalds
2008-03-06 0:35 ` Linus Torvalds
2008-03-08 22:25 ` Linus Torvalds
2008-03-08 22:36 ` Daniel Barkalow
2008-03-13 14:00 ` Jeff King
2008-03-14 14:09 ` John Goerzen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.00.0803041325370.12253@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jgoerzen@complete.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).