From: Alban Gruin <alban.gruin@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, phillip.wood@dunelm.org.uk,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH v1] builtin/rebase: remove a call to get_oid() on `options.switch_to'
Date: Fri, 14 Feb 2020 21:43:32 +0100 [thread overview]
Message-ID: <df9ede1c-f657-d96f-2d4c-479245f2a2d8@gmail.com> (raw)
In-Reply-To: <xmqq1rrr6ww2.fsf@gitster-ct.c.googlers.com>
Hi Junio,
Le 22/01/2020 à 21:47, Junio C Hamano a écrit :
> Alban Gruin <alban.gruin@gmail.com> writes:
>
>> When `options.switch_to' is set, `options.orig_head' is populated right
>> after. Therefore, there is no need to parse `switch_to' again.
>>
>> Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
>> ---
>> builtin/rebase.c | 10 +---------
>> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> Sounds good.
>
Did this patch fell through the cracks?
Alban
prev parent reply other threads:[~2020-02-14 20:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 19:32 [PATCH v1] builtin/rebase: remove a call to get_oid() on `options.switch_to' Alban Gruin
2020-01-22 14:00 ` Johannes Schindelin
2020-01-22 20:47 ` Junio C Hamano
2020-02-14 20:43 ` Alban Gruin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df9ede1c-f657-d96f-2d4c-479245f2a2d8@gmail.com \
--to=alban.gruin@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).