From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Carlo Arenas <carenas@gmail.com>,
phillip.wood@dunelm.org.uk,
Phillip Wood via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH v2 0/4] a couple of read_key_without_echo() fixes
Date: Thu, 24 Mar 2022 14:29:59 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2203241427550.388@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqy211t512.fsf@gitster.g>
Hi,
On Wed, 23 Mar 2022, Junio C Hamano wrote:
> Carlo Arenas <carenas@gmail.com> writes:
>
> > On Thu, Feb 24, 2022 at 6:30 AM Phillip Wood <phillip.wood123@gmail.com> wrote:
> >> That sounds good. I've got a couple more patches based on top of these
> >> which hopefully fix the remaining problems (notably the macos poll()
> >> bug). I'll polish and post them next week. Once those are in I hope
> >> we'll be able to enable the builtin "add -p" by default.
> >
> > As this topic just hit master noticed (I apologize for not doing it
> > sooner) the macOS problem (tested in 10.15.7) was gone (suspect fixed
> > with 1/4) and therefore enabling the builtin by default as proposed
> > originally by dscho could proceed without the additional series.
>
> As long as it is a belated success report, nobody would mind. A
> belated failure report would be a cause of sorrow and grief, but
> even then, it is better to have it late than never.
>
> Thanks for testing.
FWIW I tried to reproduce the reported issues, but since I do not have any
hardware running macOS anymore, I only had the avenue to debug via `tmate`
on one of GitHub Actions' macOS agents, but the problem did not reproduce
for me via SSH.
I am grateful for the great work put in by Carlo and Phillip to fix these
issues.
Thanks,
Dscho
next prev parent reply other threads:[~2022-03-24 13:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 10:54 [PATCH 0/3] a couple of read_key_without_echo() fixes Phillip Wood via GitGitGadget
2022-02-16 10:54 ` [PATCH 1/3] terminal: pop signal handler when terminal is restored Phillip Wood via GitGitGadget
2022-02-16 10:54 ` [PATCH 2/3] terminal: set VMIN and VTIME in non-canonical mode Phillip Wood via GitGitGadget
2022-02-16 21:40 ` Junio C Hamano
2022-02-17 10:59 ` Phillip Wood
2022-02-16 10:54 ` [PATCH 3/3] add -p: disable stdin buffering when interactive.singlekey is set Phillip Wood via GitGitGadget
2022-02-16 21:43 ` Junio C Hamano
2022-02-22 18:53 ` [PATCH v2 0/4] a couple of read_key_without_echo() fixes Phillip Wood via GitGitGadget
2022-02-22 18:53 ` [PATCH v2 1/4] terminal: always reset terminal when reading without echo Phillip Wood via GitGitGadget
2022-02-22 18:53 ` [PATCH v2 2/4] terminal: pop signal handler when terminal is restored Phillip Wood via GitGitGadget
2022-02-22 18:53 ` [PATCH v2 3/4] terminal: set VMIN and VTIME in non-canonical mode Phillip Wood via GitGitGadget
2022-02-22 18:53 ` [PATCH v2 4/4] add -p: disable stdin buffering when interactive.singlekey is set Phillip Wood via GitGitGadget
2022-02-23 21:34 ` [PATCH v2 0/4] a couple of read_key_without_echo() fixes Junio C Hamano
2022-02-24 14:30 ` Phillip Wood
2022-03-22 20:18 ` Carlo Arenas
2022-03-23 9:03 ` Junio C Hamano
2022-03-24 13:29 ` Johannes Schindelin [this message]
2022-03-28 10:51 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2203241427550.388@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).