From: "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>, Elijah Newren <newren@gmail.com>,
Elijah Newren <newren@gmail.com>
Subject: [PATCH v5 00/15] Add struct strmap and associated utility functions
Date: Fri, 06 Nov 2020 00:24:43 +0000 [thread overview]
Message-ID: <pull.835.v5.git.git.1604622298.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.835.v4.git.git.1604535765.gitgitgadget@gmail.com>
Here I introduce new strmap, strintmap, and strset types. This strmap type
was based on Peff's proposal from a couple years ago[1], but has additions
that I made as I used it, and a number of additions/changes suggested by
Peff in his reviews (and Junio in his). I also start the series off with
some changes to hashmap, based on Peff's feedback on v1 & v2.
NOTE: While en/merge-ort-impl depends on this series, there are no changes
in v5 that affect it so en/merge-ort-impl does not need a reroll.
Changes since v4:
* Make strset_add() return a boolean -- 1 if it added the value to the set,
0 if the value was already in the set.
* Add a preparatory patch to the above which adds a create_entry() helper
function so that strset_add() can bypass strmap_put().
* Add a patch which updates shortlog to use the new strset API.
[1]
https://lore.kernel.org/git/20180906191203.GA26184@sigill.intra.peff.net/
Elijah Newren (15):
hashmap: add usage documentation explaining hashmap_free[_entries]()
hashmap: adjust spacing to fix argument alignment
hashmap: allow re-use after hashmap_free()
hashmap: introduce a new hashmap_partial_clear()
hashmap: provide deallocation function names
strmap: new utility functions
strmap: add more utility functions
strmap: enable faster clearing and reusing of strmaps
strmap: add functions facilitating use as a string->int map
strmap: split create_entry() out of strmap_put()
strmap: add a strset sub-type
strmap: enable allocations to come from a mem_pool
strmap: take advantage of FLEXPTR_ALLOC_STR when relevant
Use new HASHMAP_INIT macro to simplify hashmap initialization
shortlog: use strset from strmap.h
Makefile | 1 +
add-interactive.c | 2 +-
attr.c | 26 ++--
blame.c | 2 +-
bloom.c | 5 +-
builtin/difftool.c | 9 +-
builtin/fetch.c | 6 +-
builtin/shortlog.c | 61 +--------
config.c | 2 +-
diff.c | 4 +-
diffcore-rename.c | 2 +-
dir.c | 8 +-
hashmap.c | 74 +++++++----
hashmap.h | 91 +++++++++++---
merge-recursive.c | 6 +-
name-hash.c | 4 +-
object.c | 2 +-
oidmap.c | 2 +-
patch-ids.c | 2 +-
range-diff.c | 6 +-
ref-filter.c | 2 +-
revision.c | 11 +-
sequencer.c | 4 +-
strmap.c | 178 ++++++++++++++++++++++++++
strmap.h | 268 ++++++++++++++++++++++++++++++++++++++++
submodule-config.c | 4 +-
t/helper/test-hashmap.c | 9 +-
27 files changed, 621 insertions(+), 170 deletions(-)
create mode 100644 strmap.c
create mode 100644 strmap.h
base-commit: d4a392452e292ff924e79ec8458611c0f679d6d4
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-835%2Fnewren%2Fstrmap-v5
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-835/newren/strmap-v5
Pull-Request: https://github.com/git/git/pull/835
Range-diff vs v4:
1: af6b6fcb46 = 1: af6b6fcb46 hashmap: add usage documentation explaining hashmap_free[_entries]()
2: 591161fd78 = 2: 591161fd78 hashmap: adjust spacing to fix argument alignment
3: f2718d036d = 3: f2718d036d hashmap: allow re-use after hashmap_free()
4: 61f1da3c51 = 4: 61f1da3c51 hashmap: introduce a new hashmap_partial_clear()
5: 861e8d65ae = 5: 861e8d65ae hashmap: provide deallocation function names
6: 448d3b219f = 6: 448d3b219f strmap: new utility functions
7: 5e8004c728 = 7: 5e8004c728 strmap: add more utility functions
8: fd96e9fc8d = 8: fd96e9fc8d strmap: enable faster clearing and reusing of strmaps
9: f499934f54 = 9: f499934f54 strmap: add functions facilitating use as a string->int map
-: ---------- > 10: 3bcceb8cdb strmap: split create_entry() out of strmap_put()
10: ee1ec55f1b ! 11: e128a71fec strmap: add a strset sub-type
@@ Commit message
Signed-off-by: Elijah Newren <newren@gmail.com>
+ ## strmap.c ##
+@@ strmap.c: void strintmap_incr(struct strintmap *map, const char *str, intptr_t amt)
+ else
+ strintmap_set(map, str, map->default_value + amt);
+ }
++
++int strset_add(struct strset *set, const char *str)
++{
++ /*
++ * Cannot use strmap_put() because it'll return NULL in both cases:
++ * - cannot find str: NULL means "not found"
++ * - does find str: NULL is the value associated with str
++ */
++ struct strmap_entry *entry = find_strmap_entry(&set->map, str);
++
++ if (entry)
++ return 0;
++
++ entry = create_entry(&set->map, str, NULL);
++ hashmap_add(&set->map.map, &entry->ent);
++ return 1;
++}
+
## strmap.h ##
@@ strmap.h: int cmp_strmap_entry(const void *hashmap_cmp_fn_data,
.map = STRMAP_INIT, \
@@ strmap.h: static inline void strintmap_set(struct strintmap *map, const char *st
+ return strmap_get_size(&set->map);
+}
+
-+static inline void strset_add(struct strset *set, const char *str)
-+{
-+ strmap_put(&set->map, str, NULL);
-+}
++/* Returns 1 if str is added to the set; returns 0 if str was already in set */
++int strset_add(struct strset *set, const char *str);
+
#endif /* STRMAP_H */
11: 73a57045c3 ! 12: 34f542d9dd strmap: enable allocations to come from a mem_pool
@@ strmap.c: static void strmap_free_entries_(struct strmap *map, int free_values)
}
}
-@@ strmap.c: void *strmap_put(struct strmap *map, const char *str, void *data)
- } else {
- const char *key = str;
-
-- entry = xmalloc(sizeof(*entry));
-+ entry = map->pool ? mem_pool_alloc(map->pool, sizeof(*entry))
-+ : xmalloc(sizeof(*entry));
- hashmap_entry_init(&entry->ent, strhash(str));
-
- if (map->strdup_strings)
-- key = xstrdup(str);
-+ key = map->pool ? mem_pool_strdup(map->pool, str)
-+ : xstrdup(str);
- entry->key = key;
- entry->value = data;
- hashmap_add(&map->map, &entry->ent);
+@@ strmap.c: static struct strmap_entry *create_entry(struct strmap *map,
+ struct strmap_entry *entry;
+ const char *key = str;
+
+- entry = xmalloc(sizeof(*entry));
++ entry = map->pool ? mem_pool_alloc(map->pool, sizeof(*entry))
++ : xmalloc(sizeof(*entry));
+ hashmap_entry_init(&entry->ent, strhash(str));
+
+ if (map->strdup_strings)
+- key = xstrdup(str);
++ key = map->pool ? mem_pool_strdup(map->pool, str)
++ : xstrdup(str);
+ entry->key = key;
+ entry->value = data;
+ return entry;
@@ strmap.c: void strmap_remove(struct strmap *map, const char *str, int free_value)
return;
if (free_value)
12: 0352260de4 ! 13: 39ec2fa411 strmap: take advantage of FLEXPTR_ALLOC_STR when relevant
@@ strmap.c: static void strmap_free_entries_(struct strmap *map, int free_values)
}
}
-@@ strmap.c: void strmap_partial_clear(struct strmap *map, int free_values)
- void *strmap_put(struct strmap *map, const char *str, void *data)
+@@ strmap.c: static struct strmap_entry *create_entry(struct strmap *map,
+ void *data)
{
- struct strmap_entry *entry = find_strmap_entry(map, str);
-- void *old = NULL;
+ struct strmap_entry *entry;
+- const char *key = str;
- if (entry) {
-- old = entry->value;
-+ void *old = entry->value;
- entry->value = data;
-- } else {
-- const char *key = str;
--
-- entry = map->pool ? mem_pool_alloc(map->pool, sizeof(*entry))
-- : xmalloc(sizeof(*entry));
-- hashmap_entry_init(&entry->ent, strhash(str));
-+ return old;
-+ }
-
-- if (map->strdup_strings)
-- key = map->pool ? mem_pool_strdup(map->pool, str)
-- : xstrdup(str);
-- entry->key = key;
-- entry->value = data;
-- hashmap_add(&map->map, &entry->ent);
+- entry = map->pool ? mem_pool_alloc(map->pool, sizeof(*entry))
+- : xmalloc(sizeof(*entry));
+ if (map->strdup_strings) {
+ if (!map->pool) {
+ FLEXPTR_ALLOC_STR(entry, key, str);
@@ strmap.c: void strmap_partial_clear(struct strmap *map, int free_values)
+ entry = xmalloc(sizeof(*entry));
+ } else {
+ entry = mem_pool_alloc(map->pool, sizeof(*entry));
- }
-- return old;
-+ hashmap_entry_init(&entry->ent, strhash(str));
++ }
+ hashmap_entry_init(&entry->ent, strhash(str));
+-
+- if (map->strdup_strings)
+- key = map->pool ? mem_pool_strdup(map->pool, str)
+- : xstrdup(str);
+- entry->key = key;
+ if (!map->strdup_strings)
+ entry->key = str;
-+ entry->value = data;
-+ hashmap_add(&map->map, &entry->ent);
-+ return NULL;
+ entry->value = data;
+ return entry;
}
-
- struct strmap_entry *strmap_get_entry(struct strmap *map, const char *str)
@@ strmap.c: void strmap_remove(struct strmap *map, const char *str, int free_value)
return;
if (free_value)
13: 617926540b = 14: d3713d88f2 Use new HASHMAP_INIT macro to simplify hashmap initialization
-: ---------- > 15: 24e5ce60f5 shortlog: use strset from strmap.h
--
gitgitgadget
next prev parent reply other threads:[~2020-11-06 0:25 UTC|newest]
Thread overview: 144+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 18:52 [PATCH 0/5] Add struct strmap and associated utility functions Elijah Newren via GitGitGadget
2020-08-21 18:52 ` [PATCH 1/5] hashmap: add usage documentation explaining hashmap_free[_entries]() Elijah Newren via GitGitGadget
2020-08-21 19:22 ` Jeff King
2020-08-21 18:52 ` [PATCH 2/5] strmap: new utility functions Elijah Newren via GitGitGadget
2020-08-21 19:48 ` Jeff King
2020-08-21 18:52 ` [PATCH 3/5] strmap: add more " Elijah Newren via GitGitGadget
2020-08-21 19:58 ` Jeff King
2020-08-21 18:52 ` [PATCH 4/5] strmap: add strdup_strings option Elijah Newren via GitGitGadget
2020-08-21 20:01 ` Jeff King
2020-08-21 20:41 ` Elijah Newren
2020-08-21 21:03 ` Jeff King
2020-08-21 22:25 ` Elijah Newren
2020-08-28 7:08 ` Jeff King
2020-08-28 17:20 ` Elijah Newren
2020-08-21 18:52 ` [PATCH 5/5] strmap: add functions facilitating use as a string->int map Elijah Newren via GitGitGadget
2020-08-21 20:10 ` Jeff King
2020-08-21 20:51 ` Elijah Newren
2020-08-21 21:05 ` Jeff King
2020-08-21 20:16 ` [PATCH 0/5] Add struct strmap and associated utility functions Jeff King
2020-08-21 21:33 ` Elijah Newren
2020-08-21 22:28 ` Elijah Newren
2020-08-28 7:03 ` Jeff King
2020-08-28 15:29 ` Elijah Newren
2020-09-01 9:27 ` Jeff King
2020-10-13 0:40 ` [PATCH v2 00/10] " Elijah Newren via GitGitGadget
2020-10-13 0:40 ` [PATCH v2 01/10] hashmap: add usage documentation explaining hashmap_free[_entries]() Elijah Newren via GitGitGadget
2020-10-30 12:50 ` Jeff King
2020-10-30 19:55 ` Elijah Newren
2020-11-03 16:26 ` Jeff King
2020-11-03 16:48 ` Elijah Newren
2020-10-13 0:40 ` [PATCH v2 02/10] hashmap: adjust spacing to fix argument alignment Elijah Newren via GitGitGadget
2020-10-30 12:51 ` Jeff King
2020-10-13 0:40 ` [PATCH v2 03/10] hashmap: allow re-use after hashmap_free() Elijah Newren via GitGitGadget
2020-10-30 13:35 ` Jeff King
2020-10-30 15:37 ` Elijah Newren
2020-11-03 16:08 ` Jeff King
2020-11-03 16:16 ` Elijah Newren
2020-10-13 0:40 ` [PATCH v2 04/10] hashmap: introduce a new hashmap_partial_clear() Elijah Newren via GitGitGadget
2020-10-30 13:41 ` Jeff King
2020-10-30 16:03 ` Elijah Newren
2020-11-03 16:10 ` Jeff King
2020-10-13 0:40 ` [PATCH v2 05/10] strmap: new utility functions Elijah Newren via GitGitGadget
2020-10-30 14:12 ` Jeff King
2020-10-30 16:26 ` Elijah Newren
2020-10-13 0:40 ` [PATCH v2 06/10] strmap: add more " Elijah Newren via GitGitGadget
2020-10-30 14:23 ` Jeff King
2020-10-30 16:43 ` Elijah Newren
2020-11-03 16:12 ` Jeff King
2020-10-13 0:40 ` [PATCH v2 07/10] strmap: enable faster clearing and reusing of strmaps Elijah Newren via GitGitGadget
2020-10-30 14:27 ` Jeff King
2020-10-13 0:40 ` [PATCH v2 08/10] strmap: add functions facilitating use as a string->int map Elijah Newren via GitGitGadget
2020-10-30 14:39 ` Jeff King
2020-10-30 17:28 ` Elijah Newren
2020-11-03 16:20 ` Jeff King
2020-11-03 16:46 ` Elijah Newren
2020-10-13 0:40 ` [PATCH v2 09/10] strmap: add a strset sub-type Elijah Newren via GitGitGadget
2020-10-30 14:44 ` Jeff King
2020-10-30 18:02 ` Elijah Newren
2020-10-13 0:40 ` [PATCH v2 10/10] strmap: enable allocations to come from a mem_pool Elijah Newren via GitGitGadget
2020-10-30 14:56 ` Jeff King
2020-10-30 19:31 ` Elijah Newren
2020-11-03 16:24 ` Jeff King
2020-11-02 18:55 ` [PATCH v3 00/13] Add struct strmap and associated utility functions Elijah Newren via GitGitGadget
2020-11-02 18:55 ` [PATCH v3 01/13] hashmap: add usage documentation explaining hashmap_free[_entries]() Elijah Newren via GitGitGadget
2020-11-02 18:55 ` [PATCH v3 02/13] hashmap: adjust spacing to fix argument alignment Elijah Newren via GitGitGadget
2020-11-02 18:55 ` [PATCH v3 03/13] hashmap: allow re-use after hashmap_free() Elijah Newren via GitGitGadget
2020-11-02 18:55 ` [PATCH v3 04/13] hashmap: introduce a new hashmap_partial_clear() Elijah Newren via GitGitGadget
2020-11-02 18:55 ` [PATCH v3 05/13] hashmap: provide deallocation function names Elijah Newren via GitGitGadget
2020-11-02 18:55 ` [PATCH v3 06/13] strmap: new utility functions Elijah Newren via GitGitGadget
2020-11-02 18:55 ` [PATCH v3 07/13] strmap: add more " Elijah Newren via GitGitGadget
2020-11-04 20:13 ` Jeff King
2020-11-04 20:24 ` Elijah Newren
2020-11-02 18:55 ` [PATCH v3 08/13] strmap: enable faster clearing and reusing of strmaps Elijah Newren via GitGitGadget
2020-11-02 18:55 ` [PATCH v3 09/13] strmap: add functions facilitating use as a string->int map Elijah Newren via GitGitGadget
2020-11-04 20:21 ` Jeff King
2020-11-02 18:55 ` [PATCH v3 10/13] strmap: add a strset sub-type Elijah Newren via GitGitGadget
2020-11-04 20:31 ` Jeff King
2020-11-02 18:55 ` [PATCH v3 11/13] strmap: enable allocations to come from a mem_pool Elijah Newren via GitGitGadget
2020-11-02 18:55 ` [PATCH v3 12/13] strmap: take advantage of FLEXPTR_ALLOC_STR when relevant Elijah Newren via GitGitGadget
2020-11-04 20:43 ` Jeff King
2020-11-02 18:55 ` [PATCH v3 13/13] Use new HASHMAP_INIT macro to simplify hashmap initialization Elijah Newren via GitGitGadget
2020-11-04 20:48 ` Jeff King
2020-11-04 20:52 ` [PATCH v3 00/13] Add struct strmap and associated utility functions Jeff King
2020-11-04 22:20 ` Elijah Newren
2020-11-05 0:22 ` [PATCH v4 " Elijah Newren via GitGitGadget
2020-11-05 0:22 ` [PATCH v4 01/13] hashmap: add usage documentation explaining hashmap_free[_entries]() Elijah Newren via GitGitGadget
2020-11-05 0:22 ` [PATCH v4 02/13] hashmap: adjust spacing to fix argument alignment Elijah Newren via GitGitGadget
2020-11-05 0:22 ` [PATCH v4 03/13] hashmap: allow re-use after hashmap_free() Elijah Newren via GitGitGadget
2020-11-05 0:22 ` [PATCH v4 04/13] hashmap: introduce a new hashmap_partial_clear() Elijah Newren via GitGitGadget
2020-11-05 0:22 ` [PATCH v4 05/13] hashmap: provide deallocation function names Elijah Newren via GitGitGadget
2020-11-05 0:22 ` [PATCH v4 06/13] strmap: new utility functions Elijah Newren via GitGitGadget
2020-11-05 0:22 ` [PATCH v4 07/13] strmap: add more " Elijah Newren via GitGitGadget
2020-11-05 0:22 ` [PATCH v4 08/13] strmap: enable faster clearing and reusing of strmaps Elijah Newren via GitGitGadget
2020-11-05 0:22 ` [PATCH v4 09/13] strmap: add functions facilitating use as a string->int map Elijah Newren via GitGitGadget
2020-11-05 0:22 ` [PATCH v4 10/13] strmap: add a strset sub-type Elijah Newren via GitGitGadget
2020-11-05 0:22 ` [PATCH v4 11/13] strmap: enable allocations to come from a mem_pool Elijah Newren via GitGitGadget
2020-11-05 0:22 ` [PATCH v4 12/13] strmap: take advantage of FLEXPTR_ALLOC_STR when relevant Elijah Newren via GitGitGadget
2020-11-05 0:22 ` [PATCH v4 13/13] Use new HASHMAP_INIT macro to simplify hashmap initialization Elijah Newren via GitGitGadget
2020-11-05 13:29 ` [PATCH v4 00/13] Add struct strmap and associated utility functions Jeff King
2020-11-05 20:25 ` Junio C Hamano
2020-11-05 21:17 ` Jeff King
2020-11-05 21:22 ` Elijah Newren
2020-11-05 22:15 ` Junio C Hamano
2020-11-06 0:24 ` Elijah Newren via GitGitGadget [this message]
2020-11-06 0:24 ` [PATCH v5 01/15] hashmap: add usage documentation explaining hashmap_free[_entries]() Elijah Newren via GitGitGadget
2020-11-06 0:24 ` [PATCH v5 02/15] hashmap: adjust spacing to fix argument alignment Elijah Newren via GitGitGadget
2020-11-06 0:24 ` [PATCH v5 03/15] hashmap: allow re-use after hashmap_free() Elijah Newren via GitGitGadget
2020-11-06 0:24 ` [PATCH v5 04/15] hashmap: introduce a new hashmap_partial_clear() Elijah Newren via GitGitGadget
2020-11-06 0:24 ` [PATCH v5 05/15] hashmap: provide deallocation function names Elijah Newren via GitGitGadget
2020-11-06 0:24 ` [PATCH v5 06/15] strmap: new utility functions Elijah Newren via GitGitGadget
2020-11-06 0:24 ` [PATCH v5 07/15] strmap: add more " Elijah Newren via GitGitGadget
2020-11-06 0:24 ` [PATCH v5 08/15] strmap: enable faster clearing and reusing of strmaps Elijah Newren via GitGitGadget
2020-11-06 0:24 ` [PATCH v5 09/15] strmap: add functions facilitating use as a string->int map Elijah Newren via GitGitGadget
2020-11-06 0:24 ` [PATCH v5 10/15] strmap: split create_entry() out of strmap_put() Elijah Newren via GitGitGadget
2020-11-06 0:24 ` [PATCH v5 11/15] strmap: add a strset sub-type Elijah Newren via GitGitGadget
2020-11-06 0:24 ` [PATCH v5 12/15] strmap: enable allocations to come from a mem_pool Elijah Newren via GitGitGadget
2020-11-11 17:33 ` Phillip Wood
2020-11-11 18:49 ` Elijah Newren
2020-11-11 19:01 ` Jeff King
2020-11-11 20:34 ` Chris Torek
2020-11-06 0:24 ` [PATCH v5 13/15] strmap: take advantage of FLEXPTR_ALLOC_STR when relevant Elijah Newren via GitGitGadget
2020-11-06 0:24 ` [PATCH v5 14/15] Use new HASHMAP_INIT macro to simplify hashmap initialization Elijah Newren via GitGitGadget
2020-11-06 0:24 ` [PATCH v5 15/15] shortlog: use strset from strmap.h Elijah Newren via GitGitGadget
2020-11-06 2:00 ` [PATCH v5 00/15] Add struct strmap and associated utility functions Junio C Hamano
2020-11-06 2:42 ` Elijah Newren
2020-11-06 2:48 ` Jeff King
2020-11-06 17:32 ` Junio C Hamano
2020-11-11 20:02 ` [PATCH v6 " Elijah Newren via GitGitGadget
2020-11-11 20:02 ` [PATCH v6 01/15] hashmap: add usage documentation explaining hashmap_free[_entries]() Elijah Newren via GitGitGadget
2020-11-11 20:02 ` [PATCH v6 02/15] hashmap: adjust spacing to fix argument alignment Elijah Newren via GitGitGadget
2020-11-11 20:02 ` [PATCH v6 03/15] hashmap: allow re-use after hashmap_free() Elijah Newren via GitGitGadget
2020-11-11 20:02 ` [PATCH v6 04/15] hashmap: introduce a new hashmap_partial_clear() Elijah Newren via GitGitGadget
2020-11-11 20:02 ` [PATCH v6 05/15] hashmap: provide deallocation function names Elijah Newren via GitGitGadget
2020-11-11 20:02 ` [PATCH v6 06/15] strmap: new utility functions Elijah Newren via GitGitGadget
2020-11-11 20:02 ` [PATCH v6 07/15] strmap: add more " Elijah Newren via GitGitGadget
2020-11-11 20:02 ` [PATCH v6 08/15] strmap: enable faster clearing and reusing of strmaps Elijah Newren via GitGitGadget
2020-11-11 20:02 ` [PATCH v6 09/15] strmap: add functions facilitating use as a string->int map Elijah Newren via GitGitGadget
2020-11-11 20:02 ` [PATCH v6 10/15] strmap: split create_entry() out of strmap_put() Elijah Newren via GitGitGadget
2020-11-11 20:02 ` [PATCH v6 11/15] strmap: add a strset sub-type Elijah Newren via GitGitGadget
2020-11-11 20:02 ` [PATCH v6 12/15] strmap: enable allocations to come from a mem_pool Elijah Newren via GitGitGadget
2020-11-11 20:02 ` [PATCH v6 13/15] strmap: take advantage of FLEXPTR_ALLOC_STR when relevant Elijah Newren via GitGitGadget
2020-11-11 20:02 ` [PATCH v6 14/15] Use new HASHMAP_INIT macro to simplify hashmap initialization Elijah Newren via GitGitGadget
2020-11-11 20:02 ` [PATCH v6 15/15] shortlog: use strset from strmap.h Elijah Newren via GitGitGadget
2020-11-11 20:07 ` [PATCH v6 00/15] Add struct strmap and associated utility functions Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.835.v5.git.git.1604622298.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).