From: Junio C Hamano <gitster@pobox.com>
To: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, peff@peff.net, jcoglan@gmail.com,
Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH 0/2] Graph horizontal fix
Date: Wed, 08 Jan 2020 10:06:37 -0800 [thread overview]
Message-ID: <xmqq5zhl3jrm.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <pull.518.git.1578457675.gitgitgadget@gmail.com> (Derrick Stolee via GitGitGadget's message of "Wed, 08 Jan 2020 04:27:53 +0000")
"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
> This depends on ds/graph-assert-fix.
>
> This is a non-critical (not needed for v2.25.0) response to the previous
> discussions [1] [2].
>
> While working to resolve the fix for the assert() bug, I noticed this
> regression when multiple edges wanted to collapse with horizontal lines. It
> takes a reasonably large graph, but real projects are likely to demonstrate
> this behavior.
>
> I arranged the series into two patches: 1. the (failing) test, and 2. the
> fix.
>
> The fix commit includes some details about why the change to compress merge
> commits caused this regression, and why I feel relatively confident that
> this is a correct resolution.
I am not sure if this is "fix" of "bug" in that what is shown
without 2/2 (iow, "before this change" in the description of 2/2) is
"wrong" per-se---it is just that it leaves room to be made even more
compact. It still is an improvement, of course, though.
Queued. Thanks.
>
> Thanks, -Stolee
>
> [1]
> https://lore.kernel.org/git/faa954fa-ccb9-b034-a39d-d2f0696826ea@gmail.com/T/#t
> [2]
> https://lore.kernel.org/git/xmqqk1635gwu.fsf@gitster-ct.c.googlers.com/T/#t
>
> Derrick Stolee (2):
> graph: add test to demonstrate horizontal line bug
> graph: fix collapse of multiple edges
>
> graph.c | 10 ++++--
> t/t4215-log-skewed-merges.sh | 62 ++++++++++++++++++++++++++++++++++++
> 2 files changed, 70 insertions(+), 2 deletions(-)
>
>
> base-commit: aa2121af50498c7ea9d5c4c87f9dc66605bf772b
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-518%2Fderrickstolee%2Fgraph-horizontal-fix-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-518/derrickstolee/graph-horizontal-fix-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/518
next prev parent reply other threads:[~2020-01-08 18:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 4:27 [PATCH 0/2] Graph horizontal fix Derrick Stolee via GitGitGadget
2020-01-08 4:27 ` [PATCH 1/2] graph: add test to demonstrate horizontal line bug Derrick Stolee via GitGitGadget
2020-01-08 4:27 ` [PATCH 2/2] graph: fix collapse of multiple edges Derrick Stolee via GitGitGadget
2020-01-08 7:25 ` Jeff King
2020-01-08 13:40 ` Derrick Stolee
2020-01-08 13:49 ` Jeff King
2020-01-08 18:06 ` Junio C Hamano [this message]
2020-01-08 20:05 ` [PATCH 0/2] Graph horizontal fix Derrick Stolee
2020-01-08 21:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5zhl3jrm.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jcoglan@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).