From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: git@vger.kernel.org, "Duy Nguyen" <pclouds@gmail.com>,
"Thomas Gummerer" <t.gummerer@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH 1/5] t1700-split-index: drop unnecessary 'grep'
Date: Thu, 06 Sep 2018 14:24:13 -0700 [thread overview]
Message-ID: <xmqq5zziz5du.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180906024810.8074-2-szeder.dev@gmail.com> ("SZEDER =?utf-8?Q?G=C3=A1bor=22's?= message of "Thu, 6 Sep 2018 04:48:06 +0200")
SZEDER Gábor <szeder.dev@gmail.com> writes:
> The test 'disable split index' in 't1700-split-index.sh' runs the
> following pipeline:
>
> cmd | grep <pattern> | sed s///
>
> Drop that 'grep' from the pipeline, and let 'sed' take over its
> duties.
>
> Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
> ---
Obviously good ;-) Thanks.
> t/t1700-split-index.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t1700-split-index.sh b/t/t1700-split-index.sh
> index b3b4d83eaf..be22398a85 100755
> --- a/t/t1700-split-index.sh
> +++ b/t/t1700-split-index.sh
> @@ -57,7 +57,7 @@ test_expect_success 'disable split index' '
> EOF
> test_cmp ls-files.expect ls-files.actual &&
>
> - BASE=$(test-tool dump-split-index .git/index | grep "^own" | sed "s/own/base/") &&
> + BASE=$(test-tool dump-split-index .git/index | sed -n "s/^own/base/p") &&
> test-tool dump-split-index .git/index | sed "/^own/d" >actual &&
> cat >expect <<-EOF &&
> not a split index
next prev parent reply other threads:[~2018-09-06 21:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 2:48 [RFC PATCH 0/5] Fix the racy split index problem SZEDER Gábor
2018-09-06 2:48 ` [PATCH 1/5] t1700-split-index: drop unnecessary 'grep' SZEDER Gábor
2018-09-06 21:24 ` Junio C Hamano [this message]
2018-09-08 13:50 ` Duy Nguyen
2018-09-06 2:48 ` [PATCH 2/5] t0090: disable GIT_TEST_SPLIT_INDEX for the test checking split index SZEDER Gábor
2018-09-06 8:03 ` Ævar Arnfjörð Bjarmason
2018-09-06 2:48 ` [RFC PATCH 3/5] split index: add a test to demonstrate the racy split index problem SZEDER Gábor
2018-09-06 2:48 ` [RFC PATCH 4/5] t1700-split-index: date back files to avoid racy situations SZEDER Gábor
2018-09-06 8:02 ` Ævar Arnfjörð Bjarmason
2018-09-06 9:15 ` SZEDER Gábor
2018-09-06 9:20 ` Ævar Arnfjörð Bjarmason
2018-09-06 2:48 ` [RFC PATCH 5/5] split-index: smudge and add racily clean cache entries to split index SZEDER Gábor
2018-09-06 10:26 ` Ævar Arnfjörð Bjarmason
2018-09-06 12:26 ` Ævar Arnfjörð Bjarmason
2018-09-06 15:14 ` SZEDER Gábor
2018-09-06 15:26 ` Ævar Arnfjörð Bjarmason
2018-09-06 17:53 ` Ævar Arnfjörð Bjarmason
2018-09-07 3:49 ` SZEDER Gábor
2018-09-10 22:12 ` Paul-Sebastian Ungureanu
2018-09-08 16:45 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5zziz5du.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=szeder.dev@gmail.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).