git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Yang Zhao <yang.zhao@skyboxlabs.com>
Cc: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>,
	"Git Users" <git@vger.kernel.org>
Subject: Re: [PATCH] doc: mention Python 3.x supports
Date: Tue, 15 Dec 2020 13:06:48 -0800	[thread overview]
Message-ID: <xmqq8s9y93tj.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CABvFv3JjipUqchLAhyvMax=s4z3VhPyKvSAPqtbj3W4pNOmzvg@mail.gmail.com> (Yang Zhao's message of "Tue, 15 Dec 2020 09:54:36 -0800")

Yang Zhao <yang.zhao@skyboxlabs.com> writes:

> Caveat: I am relying on memory here. I haven't looked at this code
> since my last round of PRs...
>
> Yes, git-p4 use the p4 executable, and not an integration library. p4
> has a "serialize for Python" mode which outputs in a python2.7 pickled
> format, which is still supported by python3, and this is what is used
> to receive data from the app.

Ah, OK, the mention of "not 3.x" referred to the fact that its
pickle output format is native to 2.7, but 3.x can be made to read
it (and that is how we can run with 3.x).  That makes sense.

>> Not related, but Perforce's official Python bindings supports Python 3
>> from at least 2013 [p4r13]. And they still maintain in [PyPI].
>> That binding requires compiling with Python Development files, though.
>
> Compilation from source is only required on the latest version of
> python3. p4python has wheels on PyPI, but it's consistently a minor
> version behind. At the moment wheels for 3.8 exist for all major
> platforms, but not 3.9.
>
>> > The change to INSTALL just drops the mention of 3.x; do we want to
>> > specifically say that any version of 3.x is OK, or is it generally
>> > accepted that Python 3.x is "later" than "Python 2.7"?
>
> Any 3.x is OK, as long as we are staying with interfacing with the p4
> executable directly.

It makes it a lot simpler that we do not have to say anything.  So
the patch under discussion is good as-is without any tweaks, then.

Thanks.  

      reply	other threads:[~2020-12-15 21:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10 14:30 [PATCH] doc: mention Python 3.x supports Đoàn Trần Công Danh
2020-12-14 23:00 ` Junio C Hamano
2020-12-15 17:38   ` Đoàn Trần Công Danh
2020-12-15 17:54     ` Yang Zhao
2020-12-15 21:06       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8s9y93tj.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=congdanhqx@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=yang.zhao@skyboxlabs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).