From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Barret Rhoden <brho@google.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/4] blame: validate and peel the object names on the ignore list
Date: Mon, 12 Oct 2020 09:54:59 -0700 [thread overview]
Message-ID: <xmqqa6wrqt98.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <1fa730c4-eaef-2f32-e1b4-716a27ed4646@web.de> (=?utf-8?Q?=22R?= =?utf-8?Q?en=C3=A9?= Scharfe"'s message of "Sun, 11 Oct 2020 18:03:20 +0200")
René Scharfe <l.s.r@web.de> writes:
>>>> This preexisting feature is curious. It's even documented ('An
>>>> empty file name, "", will clear the list of revs from previously
>>>> processed files.') and covered by t8013.6. Why would we need
>>>> such magic in addition to the standard negation
>>>> (--no-ignore-revs-file) for clearing the list? The latter
>>>> counters blame.ignoreRevsFile as well. *puzzled*
>>>
>>> I shared the puzzlement when I saw it, but ditto.
>>
>> I don't recall exactly. Someone on the list might have wanted to
>> both counter the blame.ignoreRevsFile and specify another file. Or
>> maybe they just wanted to counter the ignoreRevsFile, and I didn't
>> know that --no- would already do that. I'm certainly not wed to it.
>
> The first step would be to show a deprecation warning, wait a few
> releases and then remove that feature. Not sure the effort and
> potential user irritation is worth the saved conditional, doc lines
> and test. (We already established that I'm lazy.)
I do not particularly see the need to. Perhaps when somebody
complains the next time?
> Anyway, here's the patch:
> ---
> blame.c | 2 +-
> blame.h | 5 +++--
> builtin/blame.c | 16 ++++++++++++----
> object.h | 3 ++-
> 4 files changed, 18 insertions(+), 8 deletions(-)
Looks OK to me from a quick scan.
next prev parent reply other threads:[~2020-10-12 16:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 5:59 [PATCH 0/4] Clean-up around get_x_ish() Junio C Hamano
2020-09-25 5:59 ` [PATCH 1/4] t8013: minimum preparatory clean-up Junio C Hamano
2020-09-25 5:59 ` [PATCH 2/4] blame: validate and peel the object names on the ignore list Junio C Hamano
2020-09-26 16:23 ` René Scharfe
2020-09-26 17:06 ` Junio C Hamano
2020-09-26 23:58 ` Junio C Hamano
2020-09-28 13:26 ` Barret Rhoden
2020-10-11 16:03 ` René Scharfe
2020-10-12 16:54 ` Junio C Hamano [this message]
2020-10-12 20:39 ` Barret Rhoden
2020-10-13 20:12 ` René Scharfe
2020-09-25 5:59 ` [PATCH 3/4] t1506: rev-parse A..B and A...B Junio C Hamano
2020-09-25 5:59 ` [PATCH 4/4] sequencer: stop abbreviating stopped-sha file Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa6wrqt98.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=brho@google.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).