From: Junio C Hamano <gitster@pobox.com>
To: dev@kipras.org,
Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [FR] Allow `git stash create` to include untracked changes
Date: Mon, 28 Oct 2019 10:51:09 +0900 [thread overview]
Message-ID: <xmqqa79lbpte.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <d02ddc0db596771820b0cfdfae5b1504@kipras.org> (dev@kipras.org's message of "Sat, 26 Oct 2019 17:38:34 +0300")
dev@kipras.org writes:
> Would it be possible for `git stash create` to include untracked
> changes (probably the same way `git stash push --include-untracked`
> does)?
Doesn't the subcommand have -u/--include-untracked option?
... goes and looks git-stash.sh ...
create_stash () {
prepare_fallback_ident
stash_msg=
untracked=
while test $# != 0
do
case "$1" in
-m|--message)
...
;;
-u|--include-untracked)
shift
untracked=${1?"BUG: create_stash () -u requires an argument"}
;;
...
done
...
It is entirely possible that with recent push to rewrite scripted
Porcelain commands to builtin/, we may have lost a feature or two
by accident.
... goes and checks ...
And it does appear that builtin/stash.c::create_stash() lacks
support for command line arguments since d4788af8 ("stash: convert
create to builtin", 2019-02-25).
Would doing
export GIT_TEST_STASH_USE_BUILTIN=no
or
git config --global stash.usebuiltin no
help in the meantime???
next prev parent reply other threads:[~2019-10-28 1:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-26 14:38 [FR] Allow `git stash create` to include untracked changes dev
2019-10-28 1:51 ` Junio C Hamano [this message]
2019-10-28 16:03 ` Kipras Melnikovas
2019-10-29 7:29 ` Johannes Schindelin
2019-10-31 13:40 ` Thomas Gummerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa79lbpte.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=dev@kipras.org \
--cc=git@vger.kernel.org \
--cc=ungureanupaulsebastian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).