From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: git@vger.kernel.org
Subject: Re: [ANNOUNCE] Git v2.29.0-rc1
Date: Mon, 12 Oct 2020 09:33:50 -0700 [thread overview]
Message-ID: <xmqqmu0rqu8h.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <ce8f482f-9a78-6867-38ae-601bcc2c9f66@web.de> (=?utf-8?Q?=22R?= =?utf-8?Q?en=C3=A9?= Scharfe"'s message of "Sat, 10 Oct 2020 18:45:07 +0200")
René Scharfe <l.s.r@web.de> writes:
> The option --add-file in rc1 is peculiar in that it captures the value
> of --prefix at the time of left-to-right parsing. I don't know any
> other option that does that.
If you do not count the early design of "git update-index", where
you could do funky things like
git update-cache must-exist --add new-file
to affect the way each path argument is taken, that is ;-)
I am not sure if that is a useful feature, but I do not see a reason
to add more code just to forbid giving the prefix argument multiple
times. As the main archive contents taken out of tree use just the
single "--prefix", I suspect nobody would even imagine giving
multiple "--prefix".
> It gives users a way to craft in-archive
> paths, but simply adding them with their original path (just normalized
> to use slashes as directory separators) would probably suffice.
>
> The option serves a niche use case, so this weirdness might be bearable,
> but I wouldn't have expected it to be merged without debate. Perhaps
> we want to slap an "experimental" label on it?
I have no strong opinion on this.
If this "feature" were experimental and if the experiment turns out
to be a failure, would we have a viable alternative definition?
Perhaps "--add-file names an untracked file in the working tree and
the single '--prefix' that is used for entries that come from the
tree object is applied"? Or perhaps remove --add-file entirely as a
failed experiment?
next prev parent reply other threads:[~2020-10-12 16:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 15:58 [ANNOUNCE] Git v2.29.0-rc1 Junio C Hamano
2020-10-10 16:45 ` René Scharfe
2020-10-11 6:11 ` René Scharfe
2020-10-12 16:35 ` Junio C Hamano
2020-10-12 16:33 ` Junio C Hamano [this message]
2020-10-12 19:19 ` René Scharfe
2020-10-24 17:52 ` René Scharfe
2020-10-26 18:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmu0rqu8h.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).