From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] mailinfo: support format=flowed
Date: Wed, 29 Aug 2018 13:19:16 -0700 [thread overview]
Message-ID: <xmqqo9dk94vh.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: e2f2ca18-849c-0ef4-98a5-9a1379bfcec5@web.de
René Scharfe <l.s.r@web.de> writes:
> Add best-effort support for patches sent using format=flowed (RFC 3676).
> Remove leading spaces ("unstuff"), remove soft line breaks (indicated
> by space + newline), but leave the signature separator (dash dash space
> newline) alone.
>
> Warn in git am when encountering a format=flowed patch, because any
> trailing spaces would most probably be lost, as the sending MUA is
> encouraged to remove them when preparing the email.
The warning is a very good idea, but I wonder if it is loud enough
when mixed with other noise (e.g. "--whitespace=warn" for a short
series, or patch titles when applying a very long series).
Lossage of trailing spaces may even be a feature (just joking), when
the project policy makes it OK to use "am --whitespace=fix". I
usually use "am --whitespace=fix" but I used "am --whitespace=warn"
while applying this patch to preserve lines that begin with "SP SP
HT" in the sample patch.
next prev parent reply other threads:[~2018-08-29 22:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-25 21:50 [PATCH] mailinfo: support format=flowed René Scharfe
2018-08-29 20:19 ` Junio C Hamano [this message]
2018-09-04 23:19 ` Jonathan Nieder
2018-09-04 23:25 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo9dk94vh.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).