From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: "Jonathan Nieder" <jrnieder@gmail.com>,
"Stefan Beller" <sbeller@google.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>,
git-packagers@googlegroups.com,
"Han-Wen Nienhuys" <hanwen@google.com>
Subject: Re: [PATCH] Makefile: enable DEVELOPER by default
Date: Sat, 04 Aug 2018 10:19:02 -0700 [thread overview]
Message-ID: <xmqqo9eirqwp.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CACsJy8DxSDLD7B8Z+GBFOuU7d7VQ4-M=BP=wptra5rBiZGspSQ@mail.gmail.com> (Duy Nguyen's message of "Sat, 4 Aug 2018 08:38:14 +0200")
Duy Nguyen <pclouds@gmail.com> writes:
> On Sat, Aug 4, 2018 at 8:11 AM Jonathan Nieder <jrnieder@gmail.com> wrote:
>> My main concern is not about them but about other
>> people building from source in order to run (instead of to develop)
>> Git, and by extension, the people they go to for help when it doesn't
>> work. I have lots of bitter experience of -Werror being a support
>> headache and leading to bad workarounds when someone upgrades their
>> compiler and the build starts failing due to a new warning it has
>> introduced.
>
> Even old compilers can also throw some silly, false positive warnings
> (which now turn into errors) because they are not as smart as new
> ones.
I agree with both of the above. I do not think the pros-and-cons
are in favor of forcing the developer bit to everybody, even though
I am sympathetic to the desire to see people throw fewer bad changes
that waste review bandwidth by not compiling or passing its own
tests at us.
next prev parent reply other threads:[~2018-08-04 17:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-04 2:00 [PATCH] Makefile: enable DEVELOPER by default Stefan Beller
2018-08-04 2:02 ` Stefan Beller
2018-08-04 6:09 ` Jonathan Nieder
2018-08-04 6:38 ` Duy Nguyen
2018-08-04 17:19 ` Junio C Hamano [this message]
2018-08-06 16:40 ` Ævar Arnfjörð Bjarmason
2018-08-06 17:02 ` Jeff King
2018-08-06 17:04 ` Randall S. Becker
2018-08-06 17:11 ` Jonathan Nieder
2018-08-06 18:59 ` Jeff King
2018-08-06 17:39 ` Ævar Arnfjörð Bjarmason
2018-08-06 18:38 ` Stefan Beller
2018-08-06 17:02 ` Randall S. Becker
2018-08-06 17:41 ` Ævar Arnfjörð Bjarmason
2018-08-06 19:20 ` Randall S. Becker
2018-09-01 21:01 ` Kaartic Sivaraam
2018-08-05 2:42 ` Eric Sunshine
2018-08-05 3:17 ` Jonathan Nieder
2018-08-05 3:33 ` Eric Sunshine
2018-08-05 4:58 ` Eric Sunshine
2018-08-05 7:57 ` Jonathan Nieder
2018-08-31 8:33 ` [PATCH] config.mak.uname: resolve FreeBSD iconv-related compilation warning Eric Sunshine
2018-08-31 11:54 ` Ævar Arnfjörð Bjarmason
2018-08-31 18:31 ` Eric Sunshine
2018-08-31 17:00 ` Jonathan Nieder
2018-08-31 20:59 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo9eirqwp.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git-packagers@googlegroups.com \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).