From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Drew DeVault <sir@cmpwn.com>, git@vger.kernel.org
Subject: Re: Proposal: server-advertised config options
Date: Wed, 09 Sep 2020 21:27:56 -0700 [thread overview]
Message-ID: <xmqqr1ras1bn.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200910014520.GJ241078@camp.crustytoothpaste.net> (brian m. carlson's message of "Thu, 10 Sep 2020 01:45:20 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> ... We've seen security
> problems in the past with .gitmodules multiple times because it's
> server-sent config (in the repository).
Exactly. For some reason some people still seem to think that it is
wasteful that we force users to approve/reject copying from .gitmodules
to .git/config and push to read and use settings directly from the
former---I think it is a huge mistake.
> As a result, I'm very much opposed to allowing any config options to be
> copied from the server.
+1.
> It's also the standard approach that every project uses already, and it
> has the benefit that the user can inspect it at their leisure before
> running it.
+100 ;-)
prev parent reply other threads:[~2020-09-10 4:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 16:52 Proposal: server-advertised config options Drew DeVault
2020-09-07 18:49 ` Christian Couder
2020-09-07 18:49 ` Drew DeVault
2020-09-07 18:51 ` Junio C Hamano
2020-09-07 19:23 ` Drew DeVault
2020-09-07 20:52 ` brian m. carlson
2020-09-08 14:14 ` Drew DeVault
2020-09-10 1:45 ` brian m. carlson
2020-09-10 4:27 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr1ras1bn.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
--cc=sir@cmpwn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).