git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Emily Shaffer" <emilyshaffer@google.com>,
	"SZEDER Gábor" <szeder.dev@gmail.com>,
	"Miriam Rubio" <mirucam@gmail.com>,
	git@vger.kernel.org
Subject: Re: [Outreachy][PATCH] abspath: reconcile `dir_exists()` and `is_directory()`
Date: Fri, 25 Oct 2019 11:40:57 +0900	[thread overview]
Message-ID: <xmqqr231eedi.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20191024205100.GB30715@sigill.intra.peff.net> (Jeff King's message of "Thu, 24 Oct 2019 16:51:00 -0400")

Jeff King <peff@peff.net> writes:

> Yeah, I think one path forward could be:
>
>   - add path_exists(); this will work the same as file_exists(), but is
>     a better name. Keep file_exists() for now, but put a comment that
>     new calls should use path_exists().
>
>   - use path_exists() in builtin/clone.c, ditching its custom
>     dir_exists()

Both are of immediate value ;-)

>   - (optional) start converting file_exists() calls to path_exists(),
>     after confirming what each call wants (just files, or any path)

That is of lessor urgency but the result has a good documentation
value.


  reply	other threads:[~2019-10-25  2:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24  9:27 [Outreachy][PATCH] abspath: reconcile `dir_exists()` and `is_directory()` Miriam Rubio
2019-10-24 11:41 ` SZEDER Gábor
2019-10-24 18:13   ` Jeff King
2019-10-24 20:45     ` Emily Shaffer
2019-10-24 20:51       ` Jeff King
2019-10-25  2:40         ` Junio C Hamano [this message]
2019-10-24 20:57   ` Miriam R.
2019-10-25  2:45   ` Junio C Hamano
2019-10-25  8:59     ` Miriam R.
2019-10-25  9:43       ` Junio C Hamano
2019-10-25 14:47         ` Christian Couder
2019-10-25 15:23           ` Miriam R.
2019-10-26 15:30             ` Miriam R.
2019-10-26 18:05               ` Christian Couder
2019-10-26 18:42                 ` Miriam R.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr231eedi.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=emilyshaffer@google.com \
    --cc=git@vger.kernel.org \
    --cc=mirucam@gmail.com \
    --cc=peff@peff.net \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).