From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Denton Liu <liu.denton@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Gmail munges dates?
Date: Fri, 13 Dec 2019 09:52:20 -0800 [thread overview]
Message-ID: <xmqqtv64kt9n.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20191213054227.GA76445@coredump.intra.peff.net> (Jeff King's message of "Fri, 13 Dec 2019 00:42:27 -0500")
Jeff King <peff@peff.net> writes:
>> 2. Do we want to introduce a --in-body-date option or something to
>> format-patch which would include an in-body Date:, similar to the
>> in-body From:? (Also, while we're at it, maybe we could include an
>> --in-body-from to force that to happen since that's been a feature that
>> was requested in the past[2])
>
> I doubt I'd use it myself, but I wouldn't be opposed to an in-body-date
> option. You'd perhaps want to define some heuristics to avoid
> uninteresting noise. If your patch is from 10 minutes ago, and you are
> just now sending it in, adding the extra date header is mostly just
> clutter. So perhaps you'd want it to kick in when the date is more than
> N time units or something.
I do not have a fundamental objection to the --in-body-date option,
either, although I do not want to see it used when sending patches
to this list.
As long as it is a command-line per-invocation option, I do not
think you'd need any "uninteresting noise filtering" logic. A
configuration variable to always do so would cause a huge headache
to keep the behaviour sensible when sending one's own patches,
and would require such filtering, I would think.
Thanks.
next prev parent reply other threads:[~2019-12-13 20:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 1:57 Gmail munges dates? Denton Liu
2019-12-13 5:42 ` Jeff King
2019-12-13 17:52 ` Junio C Hamano [this message]
2019-12-13 17:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtv64kt9n.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).