From: Junio C Hamano <gitster@pobox.com>
To: "Jakub Narębski" <jnareb@gmail.com>
Cc: git@vger.kernel.org, Abhishek Kumar <abhishekkumar8222@gmail.com>,
Derrick Stolee <stolee@gmail.com>
Subject: Re: ak/corrected-commit-date, was Re: What's cooking in git.git (Oct 2020, #03; Mon, 19)
Date: Fri, 23 Oct 2020 09:03:44 -0700 [thread overview]
Message-ID: <xmqqv9f1gc9r.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <685afed6-f01f-5d22-80d4-00fdc11caf0a@gmail.com> ("Jakub =?utf-8?Q?Nar=C4=99bski=22's?= message of "Fri, 23 Oct 2020 16:39:30 +0200")
Jakub Narębski <jnareb@gmail.com> writes:
> On 19.10.2020 at 20:13, Junio C Hamano wrote:
>
>> * ak/corrected-commit-date (2020-10-08) 10 commits
>> - doc: add corrected commit date info
>> - commit-reach: use corrected commit dates in paint_down_to_common()
>> - commit-graph: use generation v2 only if entire chain does
>> - commit-graph: implement generation data chunk
>> - commit-graph: implement corrected commit date
>> - commit-graph: add a slab to store topological levels
>> - commit-graph: return 64-bit generation number
>> - commit-graph: consolidate fill_commit_graph_info
>> - revision: parse parent in indegree_walk_step()
>> - commit-graph: fix regression when computing Bloom filters
>> The commit-graph learned to use corrected commit dates instead of
>> the generation number to help topological revision traversal.
>> How ready is this?
>
> I am reviewing this patch series; it looks good, in a few places
> explanation in the commit message needs improvement.
>
> I think we could in patch 07/10 get a better performance for GDOV
> (overflow chunk for generation numbers) writing with an alternate
> approach, but that might wait for subsequent patch series.
Thanks.
prev parent reply other threads:[~2020-10-23 16:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 18:13 What's cooking in git.git (Oct 2020, #03; Mon, 19) Junio C Hamano
2020-10-19 18:21 ` Eric Sunshine
2020-10-20 22:59 ` Junio C Hamano
2020-10-20 19:17 ` Preparing to rewind 'next' Junio C Hamano
2020-10-20 19:37 ` Matheus Tavares Bernardino
2020-10-21 14:48 ` mr/bisect-in-c-3, was Re: What's cooking in git.git (Oct 2020, #03; Mon, 19) Johannes Schindelin
2020-10-21 20:44 ` Junio C Hamano
2020-10-21 20:45 ` Junio C Hamano
2020-10-22 13:16 ` Johannes Schindelin
2020-10-23 8:02 ` Jeff King
2020-10-23 15:27 ` Junio C Hamano
2020-10-23 19:17 ` Elijah Newren
2020-10-27 8:39 ` Jeff King
2020-10-23 14:39 ` ak/corrected-commit-date, was " Jakub Narębski
2020-10-23 16:03 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv9f1gc9r.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=abhishekkumar8222@gmail.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).