From: Junio C Hamano <gitster@pobox.com>
To: "Eric Sunshine via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Elijah Newren <newren@gmail.com>,
Fabian Stelzer <fs@gigacodes.de>,
Lessley Dennington <lessleydennington@gmail.com>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH 3/3] t: detect and signal failure within loop
Date: Mon, 22 Aug 2022 13:22:30 -0700 [thread overview]
Message-ID: <xmqqwnb0av09.fsf@gitster.g> (raw)
In-Reply-To: <31a962fd5070d68964e545fb5506d795e8845ec3.1661192802.git.gitgitgadget@gmail.com> (Eric Sunshine via GitGitGadget's message of "Mon, 22 Aug 2022 18:26:42 +0000")
"Eric Sunshine via GitGitGadget" <gitgitgadget@gmail.com> writes:
> diff --git a/t/t5329-pack-objects-cruft.sh b/t/t5329-pack-objects-cruft.sh
> index 8968f7a08d8..6049e2c1d78 100755
> --- a/t/t5329-pack-objects-cruft.sh
> +++ b/t/t5329-pack-objects-cruft.sh
> @@ -29,7 +29,7 @@ basic_cruft_pack_tests () {
> while read oid
> do
> path="$objdir/$(test_oid_to_path "$oid")" &&
> - printf "%s %d\n" "$oid" "$(test-tool chmtime --get "$path")"
> + printf "%s %d\n" "$oid" "$(test-tool chmtime --get "$path")" || exit 1
> done |
> sort -k1
> ) >expect &&
With the loop being on the upstream of a pipe, does the added "exit
1" have any effect?
Everything else in these three patches looked very sensible, but
this one I found questionable.
Thanks.
next prev parent reply other threads:[~2022-08-22 20:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 18:26 [PATCH 0/3] tests: fix broken &&-chains & abort loops on error Eric Sunshine via GitGitGadget
2022-08-22 18:26 ` [PATCH 1/3] t2407: fix broken &&-chains in compound statement Eric Sunshine via GitGitGadget
2022-08-22 18:26 ` [PATCH 2/3] t1092: fix buggy sparse "blame" test Eric Sunshine via GitGitGadget
2022-08-22 20:09 ` Derrick Stolee
2022-08-22 18:26 ` [PATCH 3/3] t: detect and signal failure within loop Eric Sunshine via GitGitGadget
2022-08-22 20:22 ` Junio C Hamano [this message]
2022-08-22 20:59 ` Junio C Hamano
2022-08-23 6:30 ` Johannes Sixt
2022-08-23 3:05 ` Elijah Newren
2022-08-28 4:50 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwnb0av09.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=fs@gigacodes.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=lessleydennington@gmail.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).