git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: David Aguilar <davvid@gmail.com>
Cc: lin.sun@zoom.us, "'Đoàn Trần Công Danh'" <congdanhqx@gmail.com>,
	"'Pratyush Yadav'" <me@yadavpratyush.com>,
	"'sunlin via GitGitGadget'" <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH v2] Enable auto-merge for meld to follow the vim-diff beharior
Date: Tue, 30 Jun 2020 08:55:25 -0700	[thread overview]
Message-ID: <xmqqwo3oeefm.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200630064800.GB1962986@gmail.com> (David Aguilar's message of "Mon, 29 Jun 2020 23:48:00 -0700")

David Aguilar <davvid@gmail.com> writes:

> Can you please submit the patch to the list here?
> Once you do, please feel free to add my sign-off:
>
> Signed-off-by: David Aguilar <davvid@gmail.com>

Thanks, but you didn't write a single line of new code in the patch,
and you are not relaying Sun Lin's patch on the author's behalf, so
Sob is probably not what you meant---it would either be Reviewed-by
(I've gone through the patch with fine toothed comb, I can answer
any questions about the change as well as the author could, and I
can stand behind it with confidence) or Acked-by (I've seen the
patch, didn't see anything outrageously wrong in it, and agree with
its general direction---I appreciate the author tacking the issue).

  reply	other threads:[~2020-06-30 15:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09  3:33 [PATCH v2] Enable auto-merge for meld to follow the vim-diff beharior lin.sun
2020-06-28  6:23 ` lin.sun
2020-06-28 10:37   ` Đoàn Trần Công Danh
2020-06-29  9:08     ` lin.sun
2020-06-30  6:48       ` David Aguilar
2020-06-30 15:55         ` Junio C Hamano [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-05-08  1:25 [PATCH] " sunlin via GitGitGadget
2020-06-09  3:19 ` [PATCH v2] " sunlin via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwo3oeefm.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=congdanhqx@gmail.com \
    --cc=davvid@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=lin.sun@zoom.us \
    --cc=me@yadavpratyush.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).