From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (193.142.43.55:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 22 Oct 2019 18:13:36 -0000 Received: from mga09.intel.com ([134.134.136.24]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1iMyf0-0004On-Tp for speck@linutronix.de; Tue, 22 Oct 2019 20:13:35 +0200 Date: Tue, 22 Oct 2019 11:07:21 -0700 From: Pawan Gupta Subject: [MODERATED] Re: [PATCH v7 03/10] TAAv7 3 Message-ID: <20191022180721.GG29216@guptapadev.amr> References: <20191022144853.GF31458@zn.tnic> <20191022170046.GD29216@guptapadev.amr> <20191022171611.GN31458@zn.tnic> MIME-Version: 1.0 In-Reply-To: <20191022171611.GN31458@zn.tnic> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: On Tue, Oct 22, 2019 at 07:16:11PM +0200, speck for Borislav Petkov wrote: > On Tue, Oct 22, 2019 at 10:00:46AM -0700, speck for Pawan Gupta wrote: > > Again this is as per the feedback to create a new file for TSX as it is > > a feature. TAA stuff stays in bugs.c. > > Well, with patchsets like that, it is always good to write a more > detailed changelog so that questions like that are answered from it. > > Your 0/x message has > > "- Refactor TSX code into new tsx.c" > > but it would be a lot more helpful if it had the "why" you did it: > > " - Carve out the TSX disabling functionality into a separate > compilation unit because it is a CPU feature." > > This sentence could be a part of the patch commit message even. Thank you for the feedback. Thanks, Pawan