[MODERATED] Re: [PATCH 4/4] more sampling fun 4

[mark gross <mgross@linux.intel.com>]

On Tue, May 05, 2020 at 12:54:22AM +0100, speck for Ben Hutchings wrote:
> On Thu, 2020-04-16 at 18:21 +0200, speck for Mark Gross wrote:
> > From: Mark Gross <mgross@linux.intel.com>
> > Subject: [PATCH 4/4] x86/speculation: Add SRBDS vulnerability and mitigation
> >  documentation
> > 
> > commit 7222a1b5b87417f22265c92deea76a6aecd0fb0f upstream
> > 
> > Add documentation for the SRBDS vulnerability and its mitigation.
> > 
> >  [ bp: Massage.
> >    jpoimboe: sysfs table strings. ]
> > 
> > Signed-off-by: Mark Gross <mgross@linux.intel.com>
> > Signed-off-by: Borislav Petkov <bp@suse.de>
> > Reviewed-by: Tony Luck <tony.luck@intel.com>
> > Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>
> > ---
> >  .../special-register-buffer-data-sampling.rst | 148 ++++++++++++++++++
> >  Documentation/hw-vuln/index.rst               |   1 +
> >  2 files changed, 149 insertions(+)
> >  create mode 100644 Documentation/admin-guide/hw-vuln/special-register-buffer-data-sampling.rst
> > 
> > diff --git a/Documentation/admin-guide/hw-vuln/special-register-buffer-data-sampling.rst b/Documentation/admin-guide/hw-vuln/special-register-buffer-data-sampling.rst
> > new file mode 100644
> > index 000000000000..6a473da80b62
> > --- /dev/null
> > +++ b/Documentation/admin-guide/hw-vuln/special-register-buffer-data-sampling.rst
> [...]
> 
> This should go under Documentation/hw-vuln as there is no admin-guide
> directory on 4.9...
> 
> > --- a/Documentation/hw-vuln/index.rst
> > +++ b/Documentation/hw-vuln/index.rst
> > @@ -13,3 +13,4 @@ are configurable at compile, boot or run time.
> >     mds
> >     tsx_async_abort
> >     multihit.rst
> > +   special-register-buffer-data-sampling.rst
> 
> ...and this index will be broken.
> 
> Ben.
> 
> -- 
> Ben Hutchings
> It's easier to fight for one's principles than to live up to them.
> 
> 
You are correct.  How's the following look?


From 67a45bf700e6ec55acaf7fabea50f2cda6c629c5 Mon Sep 17 00:00:00 2001
From: mark gross <mgross@linux.intel.com>
Date: Tue, 5 May 2020 14:20:40 -0700
Subject: [PATCH] backport put the documentation in the wrong directory WRT
 4.9.

Move special-register-buffer-data-sampling.rst to Documentation/hw-vuln

Also clean up title underlining to correct a few warnings in make
htlmdoc buy making them line up exactly with the text they are under.

Signed-off-by: Mark Gross <mgross@linux.intel.com>
---
 .../hw-vuln/special-register-buffer-data-sampling.rst       | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
 rename Documentation/{admin-guide => }/hw-vuln/special-register-buffer-data-sampling.rst (99%)

diff --git a/Documentation/admin-guide/hw-vuln/special-register-buffer-data-sampling.rst b/Documentation/hw-vuln/special-register-buffer-data-sampling.rst
similarity index 99%
rename from Documentation/admin-guide/hw-vuln/special-register-buffer-data-sampling.rst
rename to Documentation/hw-vuln/special-register-buffer-data-sampling.rst
index 47b1b3afac99..3b1ce68d2456 100644
--- a/Documentation/admin-guide/hw-vuln/special-register-buffer-data-sampling.rst
+++ b/Documentation/hw-vuln/special-register-buffer-data-sampling.rst
@@ -14,7 +14,7 @@ to the core through the special register mechanism that is susceptible
 to MDS attacks.
 
 Affected processors
---------------------
+-------------------
 Core models (desktop, mobile, Xeon-E3) that implement RDRAND and/or RDSEED may
 be affected.
 
@@ -59,7 +59,7 @@ executed on another core or sibling thread using MDS techniques.
 
 
 Mitigation mechanism
--------------------
+--------------------
 Intel will release microcode updates that modify the RDRAND, RDSEED, and
 EGETKEY instructions to overwrite secret special register data in the shared
 staging buffer before the secret data can be accessed by another logical
@@ -118,7 +118,7 @@ with the option "srbds=".  The option for this is:
   ============= =============================================================
 
 SRBDS System Information
------------------------
+------------------------
 The Linux kernel provides vulnerability status information through sysfs.  For
 SRBDS this can be accessed by the following sysfs file:
 /sys/devices/system/cpu/vulnerabilities/srbds
-- 
2.17.1