From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Michal Wajdeczko" <michal.wajdeczko@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Misc GuC CT improvements - part II (rev2)
Date: Fri, 17 Jan 2020 08:51:43 -0000 [thread overview]
Message-ID: <157925110359.26757.11706631888726300630@emeril.freedesktop.org> (raw)
In-Reply-To: <20200117082039.65644-1-michal.wajdeczko@intel.com>
== Series Details ==
Series: Misc GuC CT improvements - part II (rev2)
URL : https://patchwork.freedesktop.org/series/72071/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
2efc33c45510 drm/i915/guc: Don't GEM_BUG_ON on corrupted G2H CTB
-:53: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tail >= size'
#53: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:592:
+ if (unlikely(!IS_ALIGNED(head, 4) ||
+ !IS_ALIGNED(tail, 4) ||
+ !IS_ALIGNED(size, 4) ||
+ (tail >= size) || (head >= size))) {
-:53: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'head >= size'
#53: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:592:
+ if (unlikely(!IS_ALIGNED(head, 4) ||
+ !IS_ALIGNED(tail, 4) ||
+ !IS_ALIGNED(size, 4) ||
+ (tail >= size) || (head >= size))) {
total: 0 errors, 0 warnings, 2 checks, 66 lines checked
3fb92bd3cd12 drm/i915/guc: Don't pass CTB while writing
8eb488a458c8 drm/i915/guc: Don't pass CTB while reading
292d1303bf00 drm/i915/guc: Switch to CT_ERROR in ct_read
d31956e86e8b drm/i915/guc: Introduce CT_DEBUG
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-17 8:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 8:20 [Intel-gfx] [PATCH v2 0/5] Misc GuC CT improvements - part II Michal Wajdeczko
2020-01-17 8:20 ` [Intel-gfx] [PATCH v2 1/5] drm/i915/guc: Don't GEM_BUG_ON on corrupted G2H CTB Michal Wajdeczko
2020-01-17 8:20 ` [Intel-gfx] [PATCH v2 2/5] drm/i915/guc: Don't pass CTB while writing Michal Wajdeczko
2020-01-17 8:20 ` [Intel-gfx] [PATCH v2 3/5] drm/i915/guc: Don't pass CTB while reading Michal Wajdeczko
2020-01-17 8:20 ` [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Switch to CT_ERROR in ct_read Michal Wajdeczko
2020-01-17 9:51 ` Piotr Piórkowski
2020-01-17 8:20 ` [Intel-gfx] [PATCH v2 5/5] drm/i915/guc: Introduce CT_DEBUG Michal Wajdeczko
2020-01-17 8:51 ` Patchwork [this message]
2020-01-17 9:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Misc GuC CT improvements - part II (rev2) Patchwork
2020-01-17 9:16 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2020-01-20 11:30 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157925110359.26757.11706631888726300630@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).