From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 9/9] drm/i915: Fold the DPLL limit defines
 into the structs that use them.
Date: Thu, 31 Mar 2011 09:12:56 -0700
Message-ID: <20110331091256.5c653799@jbarnes-desktop>
References: <1301515270-3768-1-git-send-email-eric@anholt.net>
	<1301515270-3768-10-git-send-email-eric@anholt.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from outbound-mail-01.bluehost.com (cpoproxy1-pub.bluehost.com
	[69.89.21.11])
	by gabe.freedesktop.org (Postfix) with SMTP id 2F6D89E975
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 31 Mar 2011 09:13:01 -0700 (PDT)
In-Reply-To: <1301515270-3768-10-git-send-email-eric@anholt.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Eric Anholt <eric@anholt.net>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, 30 Mar 2011 13:01:10 -0700
Eric Anholt <eric@anholt.net> wrote:

> They're used in one place, and not providing any descriptive value,
> with their names just being approximately the conjunction of the
> struct name and the struct field.
> 
> This diff was produced with gcc -E, copying the new struct definitions
> out, moving a couple of the old comments into place in the new
> structs, and reindenting.
> 
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
>  drivers/gpu/drm/i915/intel_display.c |  650 ++++++++++------------------------
>  1 files changed, 181 insertions(+), 469 deletions(-)

Yes!

Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center