From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 27/30] drm/i915: Invalidate fenced read domains upon flush Date: Wed, 13 Apr 2011 23:02:47 +0200 Message-ID: <20110413210246.GQ3660@viiv.ffwll.ch> References: <1302640318-23165-1-git-send-email-chris@chris-wilson.co.uk> <1302640318-23165-28-git-send-email-chris@chris-wilson.co.uk> <20110413194357.GI3660@viiv.ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f43.google.com (mail-ww0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id A3ED39F39A for ; Wed, 13 Apr 2011 14:02:52 -0700 (PDT) Received: by wwb17 with SMTP id 17so1025310wwb.12 for ; Wed, 13 Apr 2011 14:02:51 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Apr 13, 2011 at 09:38:50PM +0100, Chris Wilson wrote: > Whenever we finish reading an object through a fence, for safety we > clear any GPU read domain and so invalidate any TLBs associated with > the fenced region upon its next use. As we now always flush writes > through an existing fence before it is released and then trigger the > invalidation of the GPU domains should we ever re-use it again on the > GPU, we no longer need to compare and force the invalidation if the > fenced access changes in move_to_gpu(). Sounds good. And now I need some sleep, so the next mail will take longer to answer ;-) Cheers, Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48