intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Lyude Paul <lyude@redhat.com>
To: intel-gfx@lists.freedesktop.org
Cc: David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v3 0/5] drm/i915: eDP DPCD aux backlight fixes
Date: Thu, 16 Jan 2020 16:16:07 -0500	[thread overview]
Message-ID: <20200116211623.53799-1-lyude@redhat.com> (raw)

I recently got a ThinkPad X1 Extreme 2nd Generation for fixing some
issues on, and noticed that out of the box the backlight doesn't work.
Along the way of fixing that, I found a few issues with how i915 handles
DPCD AUX backlight control and fixed them. Now I've got working
backlight controls, hooray!

Note that this patch series enables DPCD backlight controls by default.
This time however, we ignore the backlight type advertised in the VBT
(unless it's a custom backlight interface that doesn't use the standard
VESA interface over AUX) and just trust the DPCD.

Lyude Paul (5):
  drm/i915: Fix eDP DPCD aux max backlight calculations
  drm/i915: Assume 100% brightness when not in DPCD control mode
  drm/i915: Fix DPCD register order in intel_dp_aux_enable_backlight()
  drm/i915: Don't use VBT for detecting DPCD backlight controls
  drm/i915: Auto detect DPCD backlight support by default

 .../drm/i915/display/intel_display_types.h    |   3 +
 .../drm/i915/display/intel_dp_aux_backlight.c | 175 ++++++++++++------
 drivers/gpu/drm/i915/i915_params.c            |   2 +-
 drivers/gpu/drm/i915/i915_params.h            |   2 +-
 4 files changed, 126 insertions(+), 56 deletions(-)

-- 
2.24.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2020-01-16 21:16 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-16 21:16 Lyude Paul [this message]
2020-01-16 21:16 ` [Intel-gfx] [PATCH v3 1/5] drm/i915: Fix eDP DPCD aux max backlight calculations Lyude Paul
2020-01-16 21:16 ` [Intel-gfx] [PATCH v3 2/5] drm/i915: Assume 100% brightness when not in DPCD control mode Lyude Paul
2020-01-16 21:16 ` [Intel-gfx] [PATCH v3 3/5] drm/i915: Fix DPCD register order in intel_dp_aux_enable_backlight() Lyude Paul
2020-01-16 21:16 ` [Intel-gfx] [PATCH v3 4/5] drm/i915: Don't use VBT for detecting DPCD backlight controls Lyude Paul
2020-01-17 11:36   ` Jani Nikula
2020-01-17 11:47     ` Jani Nikula
2020-01-17 20:24     ` Lyude Paul
2020-01-17 23:21   ` [Intel-gfx] [PATCH v4] " Lyude Paul
2020-01-22  9:17     ` Jani Nikula
2020-01-16 21:16 ` [Intel-gfx] [PATCH v3 5/5] drm/i915: Auto detect DPCD backlight support by default Lyude Paul
2020-01-16 23:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: eDP DPCD aux backlight fixes (rev6) Patchwork
2020-01-16 23:26 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2020-01-18  3:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: eDP DPCD aux backlight fixes (rev7) Patchwork
2020-01-18  3:23 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2020-01-20  5:16 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: eDP DPCD aux backlight fixes (rev6) Patchwork
2020-01-20 19:55 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: eDP DPCD aux backlight fixes (rev7) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200116211623.53799-1-lyude@redhat.com \
    --to=lyude@redhat.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).