From: Andi Shyti <andi@etezian.org>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: make a gt sysfs group and move power management files
Date: Sun, 9 Feb 2020 17:50:43 +0200 [thread overview]
Message-ID: <20200209155043.GA38454@jack.zhora.eu> (raw)
In-Reply-To: <877e0vwyri.fsf@intel.com>
Hi Jani,
> > void intel_gt_init_early(struct intel_gt *gt, struct drm_i915_private *i915)
> > {
> > @@ -321,6 +322,7 @@ void intel_gt_driver_register(struct intel_gt *gt)
> > intel_rps_driver_register(>->rps);
> >
> > debugfs_gt_register(gt);
>
> Yikes, when did this happen? Not good. We don't own the debugfs
> "namespace" prefix.
>
> > + sysfs_gt_register(gt);
>
> Ditto for the sysfs namespace prefix.
>
> I guess it's not likely debugfs or sysfs would add functions named like
> that, but if they did, they'd be right to call these names a violation
> of their namespace.
>
> I have been promoting the idea of naming functions somewhat based on the
> name of the file they reside in... so do we want to name the files like
> this either?
Yes, you're right here. I will rename the "debugfs" function and
fix the sysfs in my next patch.
Thanks,
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-09 15:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-08 12:27 [Intel-gfx] [PATCH] drm/i915/gt: make a gt sysfs group and move power management files Andi Shyti
2020-02-08 15:15 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-02-08 15:16 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-02-08 15:48 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-02-08 16:26 ` [Intel-gfx] [PATCH] " Chris Wilson
2020-02-08 16:51 ` Andi Shyti
2020-02-08 16:57 ` Chris Wilson
2020-02-08 17:01 ` Andi Shyti
2020-02-08 17:06 ` Chris Wilson
2020-02-08 17:23 ` Andi Shyti
2020-02-09 15:45 ` Jani Nikula
2020-02-09 15:50 ` Andi Shyti [this message]
2020-02-14 11:03 Andi Shyti
2020-02-14 12:54 ` Tvrtko Ursulin
2020-02-14 13:16 ` Andi Shyti
2020-02-14 13:38 ` Tvrtko Ursulin
2020-02-14 13:57 ` Andi Shyti
2020-02-14 13:18 ` Chris Wilson
2020-02-14 13:41 ` Tvrtko Ursulin
2020-02-14 13:14 ` Chris Wilson
2021-10-14 0:08 Andi Shyti
2021-10-14 23:51 ` Sundaresan, Sujaritha
2021-10-17 20:48 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200209155043.GA38454@jack.zhora.eu \
--to=andi@etezian.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).