From: "Navare, Manasi" <manasi.d.navare@intel.com>
To: Khaled Almahallawy <khaled.almahallawy@intel.com>
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/dp: DPTX writes Swing/Pre-emphs(DPCD 0x103-0x106) requested during PHY Layer testing.
Date: Mon, 24 Aug 2020 14:12:53 -0700 [thread overview]
Message-ID: <20200824211253.GA18456@labuser-Z97X-UD5H> (raw)
In-Reply-To: <20200822064837.3276-1-khaled.almahallawy@intel.com>
On Fri, Aug 21, 2020 at 11:48:37PM -0700, Khaled Almahallawy wrote:
> Source needs to write DPCD 103-106 after receiving a PHY request to change
> swing/pre-emphasis after reading DPCD 206-207. This is especially needed if
> there is a retimer between source and sink and the retimer implements AUX_CH
> interception scheme to manage DP PHY settings (e.g. adjusting Swing/Pre-emphasis
> equalization level) for DP output channel . If the source doesn't write to
> DPCD 103-106, the retimer may not output the requested swing/pre-emphasis and
> eventually we fail compliance.
>
> Signed-off-by: Khaled Almahallawy <khaled.almahallawy@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 79c27f91f42c..5044201ca742 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -5503,6 +5503,9 @@ void intel_dp_process_phy_request(struct intel_dp *intel_dp)
>
> intel_dp_autotest_phy_ddi_enable(intel_dp, data->num_lanes);
>
> + drm_dp_dpcd_write(&intel_dp->aux, DP_TRAINING_LANE0_SET,
> + intel_dp->train_set, intel_dp->lane_count);
Does this also help with spitting out the correct voltage levels during the actual training
Does this fix LT failure seen on Type C ports with retimers?
Manasi
> +
> drm_dp_set_phy_test_pattern(&intel_dp->aux, data,
> link_status[DP_DPCD_REV]);
> }
> --
> 2.17.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-08-24 21:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-22 6:48 [Intel-gfx] [PATCH] drm/i915/dp: DPTX writes Swing/Pre-emphs(DPCD 0x103-0x106) requested during PHY Layer testing Khaled Almahallawy
2020-08-22 7:08 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-08-22 7:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-08-22 8:35 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-08-24 21:12 ` Navare, Manasi [this message]
2021-01-13 15:04 ` [Intel-gfx] [PATCH] " Imre Deak
2021-01-19 7:43 ` Almahallawy, Khaled
2021-01-19 17:26 ` Imre Deak
2021-02-26 8:15 ` [Intel-gfx] [PATCH v2] " Khaled Almahallawy
2021-07-06 22:30 ` Almahallawy, Khaled
2021-07-29 16:50 ` Imre Deak
2021-02-26 8:52 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: DPTX writes Swing/Pre-emphs(DPCD 0x103-0x106) requested during PHY Layer testing. (rev2) Patchwork
2021-02-26 9:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-02-26 11:24 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824211253.GA18456@labuser-Z97X-UD5H \
--to=manasi.d.navare@intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=khaled.almahallawy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).