From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: Disable semaphore inter-engine sync without timeslicing
Date: Thu, 21 May 2020 10:10:10 +0100 [thread overview]
Message-ID: <5afb5457-733b-b057-dd6b-5040f5f9b5e8@linux.intel.com> (raw)
In-Reply-To: <20200521085320.906-1-chris@chris-wilson.co.uk>
On 21/05/2020 09:53, Chris Wilson wrote:
> Since the remove of the no-semaphore boosting, we rely on timeslicing to
> reorder past inter-dependency hogs across the engines. However, we
> require preemption to support timeslicing into user payloads, and not all
> machine support preemption so we do not universally enable timeslicing
> even when it would preempt our own inter-engine semaphores.
>
> Testcase: igt/gem_exec_schedule/semaphore-codependency # bdw/bsw
> Fixes: 18e4af04d218 ("drm/i915: Drop no-semaphore boosting")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_context.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> index 900ea8b7fc8f..f5d59d18cd5b 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> @@ -230,7 +230,7 @@ static void intel_context_set_gem(struct intel_context *ce,
> ce->timeline = intel_timeline_get(ctx->timeline);
>
> if (ctx->sched.priority >= I915_PRIORITY_NORMAL &&
> - intel_engine_has_semaphores(ce->engine))
> + intel_engine_has_timeslices(ce->engine))
> __set_bit(CONTEXT_USE_SEMAPHORES, &ce->flags);
> }
>
> @@ -1969,7 +1969,7 @@ static int __apply_priority(struct intel_context *ce, void *arg)
> {
> struct i915_gem_context *ctx = arg;
>
> - if (!intel_engine_has_semaphores(ce->engine))
> + if (!intel_engine_has_timeslices(ce->engine))
> return 0;
>
> if (ctx->sched.priority >= I915_PRIORITY_NORMAL)
>
__i915_request_await_execution is okay to keep using semaphores?
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-05-21 9:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 8:53 [Intel-gfx] [PATCH 1/2] drm/i915: Disable semaphore inter-engine sync without timeslicing Chris Wilson
2020-05-21 8:53 ` [Intel-gfx] [PATCH 2/2] drm/i915: Avoid using rq->engine after free during i915_fence_release Chris Wilson
2020-05-21 9:13 ` Tvrtko Ursulin
2020-05-21 9:27 ` Chris Wilson
2020-05-21 9:32 ` Chris Wilson
2020-05-21 9:44 ` Chris Wilson
2020-05-21 13:57 ` Tvrtko Ursulin
2020-05-21 8:55 ` [Intel-gfx] [PATCH] drm/i915: Disable semaphore inter-engine sync without timeslicing Chris Wilson
2020-05-21 9:10 ` Tvrtko Ursulin [this message]
2020-05-21 9:42 ` [Intel-gfx] [PATCH 1/2] " Chris Wilson
2020-05-21 10:17 ` Chris Wilson
2020-05-21 13:58 ` Tvrtko Ursulin
2020-05-21 10:00 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with drm/i915: Disable semaphore inter-engine sync without timeslicing (rev2) Patchwork
2020-05-21 10:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-05-22 2:28 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5afb5457-733b-b057-dd6b-5040f5f9b5e8@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).